New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(feed): Remove this useless useEffect used for Video render #1350

Open

WaDadidou opened this issue Nov 14, 2024 · 0 comments

Labels

Collaborator

WaDadidou commented Nov 14, 2024

It's here: https://github.com/TERITORI/teritori-dapp/blob/main/packages/screens/FeedPostView/components/FeedPostDefaultView.tsx#L57-L62

Why removing that ?

FeedPostDefaultView is only called in FeedPostView, but this useEffect redirects to FeedPostView.
Also, the PostCategory.Video case is already handled in FeedPostView: https://github.com/TERITORI/teritori-dapp/blob/main/packages/screens/FeedPostView/FeedPostView.tsx#L81-L82.
So, there is no reason to redirect to FeedPostView for the PostCategory.Video case

The text was updated successfully, but these errors were encountered:

WaDadidou added the Social Feed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment