Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect Against Abusive Currency Exchange During Overpay #1506

Open
joekiller opened this issue Feb 28, 2023 · 1 comment
Open

Protect Against Abusive Currency Exchange During Overpay #1506

joekiller opened this issue Feb 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@joekiller
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
People can offer a key for a 0.05 priced item and the bot will dump all the metal it has for the key even if it isn't selling metal for keys.

Describe the feature you'd like
I had a few ideas:
a. Create an option to deny trades where a key is not in the sale price of the item.
b. Create an option to limit the overpay of currency to a certain percentage of the sale price, say up to ~10% overpay of the value of the item, to help make change.

@joekiller joekiller added the enhancement New feature or request label Feb 28, 2023
@zudsniper
Copy link

...
@joekiller

Those options seem like a good way to combat this. My bot is currently stuck with keys but no ref, I would assume for this reason. In regards to (b), the percentage should probably be configurable. Good ideas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants