Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to fill a vertically-filled page with blank data rows. #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TDHewson
Copy link

@TDHewson TDHewson commented Apr 5, 2019

By providing the REPORT_FILL_DETAIL_WITH_BLANK_ROWS parameter, a vertically-filled report can have the page's detail section filled with blank data elements; see BandFillTest.

@TDHewson TDHewson force-pushed the vertical-fill-blanks branch from 6f07ad1 to 4e73b87 Compare April 5, 2019 07:56
@ozawa-hi
Copy link

ozawa-hi commented Apr 7, 2019

Filling rows may be used in 3 places. (I haven't encountered a situation where it's necessary in crosstab). It's better if all these would be handle in the same way with the same property.

  1. Directly in details band
  2. In List component
  3. In Table component

List component and Table component may have specified height that's less than the height of the page. As such, it may be better to fill to specified number of rows.

Also, it maybe better to specify using "properties" instead of "parameter"

@TDHewson
Copy link
Author

Hi Hitoshi,

Thank you for your response!

The specific cases where I'm interested in the above functionality is in the List/Table component cases, but of course it would be better for any approach to work for all cases.

Filling to a specified number of rows was what I attempted at first, however as the new test in my latest push attempts to demonstrate, it is not always possible to determine exactly how many empty rows to add to fill the last page when some of the data causes cells to stretch and span multiple lines, which is what I want to happen; I don't want cell data to be truncated. For this reason, my changes cause the final page to be filled after the main dataset has been exhausted - at this point, we know we just need to add empty rows until the page is full.

I completely agree that using "properties" instead of a "parameter" is a better approach. Do you have a recommendation as to how to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants