Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feedback endpoint #948

Open
Tmpecho opened this issue Mar 3, 2025 · 1 comment · May be fixed by #950
Open

Fix feedback endpoint #948

Tmpecho opened this issue Mar 3, 2025 · 1 comment · May be fixed by #950
Assignees
@Tmpecho @EmilJohns1 @LeMiTam

Comments

@Tmpecho
Copy link
Contributor

Tmpecho commented Mar 3, 2025

Right now, we have an endpoint at .../feedbacks/votes. We want to change this to .../feedbacks, where this returns upvotes and downvotes as well instead of or in addition to reactions.
@Tmpecho Tmpecho linked a pull request Mar 3, 2025 that will close this issue
feat(feedback)/feedback-v3 #950
Draft
3 tasks
@Tmpecho Tmpecho removed a link to a pull request Mar 3, 2025
feat(feedback)/feedback-v3 #950
Draft
3 tasks
@Tmpecho Tmpecho linked a pull request Mar 3, 2025 that will close this issue
feat(feedback)/feedback-v3 #950
Draft
3 tasks
@Tmpecho Tmpecho linked a pull request Mar 3, 2025 that will close this issue
Draft
3 tasks
@Tmpecho
Copy link
Contributor Author

Tmpecho commented Mar 10, 2025

We need to do the switching from upvote to downvote or vice versa with a transaction or something similar, as right now there's a race condition calling delete and post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tmpecho Tmpecho

@EmilJohns1 EmilJohns1

@LeMiTam LeMiTam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(feedback)/feedback-v3 TIHLDE/Lepton
3 participants
@Tmpecho @EmilJohns1 @LeMiTam