Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dattri.algorithm] Fix unsqueeze type artifact for vmap usage #86

Open
tingwl0122 opened this issue May 30, 2024 · 1 comment
Open

[dattri.algorithm] Fix unsqueeze type artifact for vmap usage #86

tingwl0122 opened this issue May 30, 2024 · 1 comment

Comments

@tingwl0122
Copy link
Collaborator

For most of the algorithms we implemented, we use some specific dimension manipulation to make vmap work on batched gradient computation. We will fix this for all the algorithms afterward. (originally mentioned in #83 )

@TheaperDeng
Copy link
Collaborator

I am still not very confident about the design of this. But it's not super urgent I think. Let's wait for some feedback and make a final decision after 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants