Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added normalised roomcodes to search for #1766

Merged
merged 7 commits into from
Jan 16, 2025
Merged

added normalised roomcodes to search for #1766

merged 7 commits into from
Jan 16, 2025

Conversation

BaumBanane
Copy link
Contributor

@BaumBanane BaumBanane commented Jan 15, 2025 •
edited
Loading

Fixes #1733

Proposed Change(s)

  • added room_code, room_code_normalised and arch_name_normalised to the exported room data
  • added these attributes to the searchable attributes in meilisearch.rs, removed ms_id (now replaced with room_code containing '.' as separator instead of '-')
  • added normalise_id to export.py to calculate the normalised room_code_normalised and arch_name_normalised
  • fixed a tiny typo in the lexer

Checklist

  • Documentation
    • I have updated the documentation
    • No need to update the documentation

@CommanderStorm
Copy link
Member

CommanderStorm commented Jan 16, 2025 •
edited
Loading

PSA:
Never open a PR from your protected branch (main/master).
This prohibits "Maintainers are allowed to edit this pull request" in some cases.

@CommanderStorm
Copy link
Member

lets test it in prod ^^

@CommanderStorm CommanderStorm merged commit 4d2ce93 into TUM-Dev:main Jan 16, 2025
@CommanderStorm CommanderStorm mentioned this pull request Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommanderStorm CommanderStorm CommanderStorm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searching for Substrings of the room name / number („Raumkennung“)
2 participants
@BaumBanane @CommanderStorm