Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing equals expression when building query in StaticDatabaseMapper #287

Closed
wants to merge 1 commit into from
Closed

Add missing equals expression when building query in StaticDatabaseMapper #287

wants to merge 1 commit into from

Conversation

stefanwimmer128
Copy link

@stefanwimmer128 stefanwimmer128 commented Aug 18, 2023 •
edited
Loading

The query in the StaticDatabaseMapper is not constructed correctly since no equals expression is used when adding the where conditions.

This PR adds that missing equals expression. Fixes #249.

@stefanwimmer128 stefanwimmer128 changed the title Add missing equals expression when building query in StaticDatabaseMa… Add missing equals expression when building query in StaticDatabaseMapper Aug 18, 2023
@andreaskienast
Copy link
Member

Hello @stefanwimmer128,
unfortunately, I didn't see your PR earlier. I've fixed the same issue with 4ba5e6f.

Kind regards
Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing query-builder-expression leads to wrong SQL-query and false results
2 participants
@stefanwimmer128 @andreaskienast