feat(vscode-webui): Handle auto approve properly in each session #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the `autoApprove` state management by moving it from a persistent store to a session-based state. This ensures that the auto-approve setting is reset for each new session, preventing unintended tool execution approvals across different tasks. Key changes: - Removed `autoApprove` from the persistent settings store. - Introduced a new session-based store for `autoApprove`. - Updated components to use the new session-based state. - Added i18n for new UI text. This change improves security and user experience by ensuring that the auto-approve setting is intentionally set for each session. 🤖 Generated with [Pochi](https://getpochi.com) Co-Authored-By: Pochi <[email protected]>
wsxiaoys
reviewed
Nov 8, 2025
| autoApproveSettings, | ||
| subtaskOffhand, | ||
| }); | ||
| setTimeout(() => { |
Member
There was a problem hiding this comment.
is this necessary? we already await the persist?
Contributor
Author
There was a problem hiding this comment.
This is to display the persistent success icon for one second
zwpaper
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the
autoApprovestate management in the VS Code Web UI. TheautoApprovestate has been moved from a persistent store to a session-based state. This ensures that the auto-approve setting is reset for each new session, preventing unintended tool execution approvals across different tasks.Key changes include:
autoApprovefrom the persistent settings store.autoApprove.This change enhances security and user experience by ensuring that the auto-approve setting is intentionally configured for each session.
Test plan
🤖 Generated with Pochi