Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rotation of screen causing blacklist to refresh #48

Open
kgursu opened this issue Mar 10, 2022 · 3 comments
Open

Fix rotation of screen causing blacklist to refresh #48

kgursu opened this issue Mar 10, 2022 · 3 comments
Labels
bug Something isn't working properly

Comments

@kgursu
Copy link

kgursu commented Mar 10, 2022

Can we have a blacklisting option on crash notification of that app? I have a large database of apps installed on my device. So, it takes a lot to scan and also, I'm not sure rotating the screen breaks it or not.
Thanks.
@TacoTheDank
Copy link
Owner

I'm not sure rotating the screen breaks it or not.

I'm not sure what you mean. Could you elaborate?

@kgursu
Copy link
Author

kgursu commented Mar 23, 2022

On some apps the rotation of screen refreshes the task it is running, in this case scanning of all apps. It might occur in this regard, I'm not sure about it...

@TacoTheDank
Copy link
Owner

TacoTheDank commented Mar 23, 2022 •
edited
Loading

Ok, so it does refresh when the device is rotated. However, this can be solved by making the activity use a ViewModel. This is something I need to work on.

@TacoTheDank TacoTheDank added the enhancement Enhancement to existing feature or functionality label Apr 6, 2022
@X1nto X1nto mentioned this issue Apr 29, 2022
Open
@TacoTheDank TacoTheDank changed the title Blacklisting recommendation Fix rotation of screen causing blacklist to refresh Apr 29, 2022
@TacoTheDank TacoTheDank added bug Something isn't working properly and removed enhancement Enhancement to existing feature or functionality labels Apr 29, 2022
unbiaseduser pushed a commit to unbiaseduser/Scoop that referenced this issue Oct 24, 2022
@unbiaseduser-github
Some more small changes, fixes upstream TacoTheDank#48
38d6911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working properly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TacoTheDank @kgursu