Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoop sometimes crashes when capturing traceback #50

Open
jrabinow opened this issue Mar 22, 2022 · 14 comments
Open

Scoop sometimes crashes when capturing traceback #50

jrabinow opened this issue Mar 22, 2022 · 14 comments
Labels
bug Something isn't working properly

Comments

@jrabinow
Copy link

jrabinow commented Mar 22, 2022

An app crashed while I was using it. Almost immediately I got a scoop notification, but it was a scoop crash, not a crash for the app I was using.

Given the timing, I'm assuming scoop crashed when trying to capture a traceback for the other app.

This has happened twice in the last 6h, I switched from the old xposed repo version to the fdroid app just yesterday. Speaking of which, many thanks for maintaining scoop, I was glad to see someone had adopted it.

java.lang.IllegalArgumentException: fromIndex(1) > toIndex(0)
	at java.util.ArrayList.subListRangeCheck(ArrayList.java:1018)
	at java.util.ArrayList.subList(ArrayList.java:1008)
	at taco.scoop.core.service.detector.CrashDetector.reportCrash(CrashDetector.kt:64)
	at taco.scoop.core.service.detector.CrashDetector.access$reportCrash(CrashDetector.kt:11)
	at taco.scoop.core.service.detector.CrashDetector$readThread$1.run(CrashDetector.kt:29)
@TacoTheDank TacoTheDank added the bug Something isn't working properly label Mar 22, 2022
@TacoTheDank
Copy link
Owner

TacoTheDank commented Mar 23, 2022

🤔 Interesting, I haven't seen anyone experience something like this before...

I was glad to see someone had adopted it.

You are most welcome! I had been using an improved forked version for about two years before I decided to upgrade it as it was looking shabby :)

@TacoTheDank TacoTheDank changed the title Bug - scoop sometimes crashes when capturing traceback Scoop sometimes crashes when capturing traceback Mar 23, 2022
@TacoTheDank
Copy link
Owner

TacoTheDank commented Mar 23, 2022

@jrabinow What Xposed system are you using? Are you still using the old Xposed, or have you updated to something like EdExposed, LSPosed, or something like that? Or, are you not using Xposed and simply relying on the root permission instead? Also, what Android version? Might not be related, but just in case.

@jrabinow
Copy link
Author

I'm on EdXposed but I haven't rebooted to activate the module yet, so right now things should be working in root-only mode. I'm running android 10

@jrabinow
Copy link
Author

I should also mention, there's one possibility which could be nasty for users, where scoop crashes while collecting its own stack trace, and produces a stack trace while doing so, which then goes on to be collected by scoop, which crashes again and so on. This could lead to an infinite crash loop of sorts
Thankfully this isn't happening here… could this scenario happen? Could anything be done to prevent it?

@jrabinow
Copy link
Author

jrabinow commented Apr 7, 2022

I rebooted and have been using the xposed module since 2 days after this issue was created. I just got the same crash twice in a row

@mjain234

This comment was marked as off-topic.

@TacoTheDank

This comment was marked as off-topic.

@mjain234

This comment was marked as off-topic.

@TacoTheDank

This comment was marked as off-topic.

@mjain234

This comment was marked as off-topic.

@TacoTheDank

This comment was marked as off-topic.

@quantenzitrone
Copy link

i think i just had the same problem
some saved stacktrace seemed to crash scoop every time i do anything other than being in the crash log overview, so

  • when i click on any stacktrace to view it (and copy it)
  • when i go to the settings
  • when i leave the app

I don't know which stacktrace it was, and i wouldn't be able to send it to you anyway, because scoop wouldn't let me view the traces.
Anyway, I cleared all saved traces, and now it seems to work again.

My phone is a SHIFT6m with a custom ungoogled ROM by the manufacturer with Magisk Root.

@TacoTheDank
Copy link
Owner

@quantenzitrone That sounds like #45.

@quantenzitrone
Copy link

yeah thats sounds more like it
i probably had a large number of crashes too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

No branches or pull requests

4 participants