From 97f823282f712d87c6f0ca611b54e8123ccb076c Mon Sep 17 00:00:00 2001 From: smouillour Date: Tue, 17 Oct 2023 19:27:12 +0200 Subject: [PATCH] fix issue with dynamic-cdn-webpack-plugin --- .github/actions/setup-node/action.yml | 7 +++---- .github/workflows/pr-playground.yml | 3 +++ .tool-versions | 4 +++- fork/dynamic-cdn-webpack-plugin/src/find.test.js | 1 - package.json | 4 ++-- 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/actions/setup-node/action.yml b/.github/actions/setup-node/action.yml index a9c0801fa43..44dabdc99df 100644 --- a/.github/actions/setup-node/action.yml +++ b/.github/actions/setup-node/action.yml @@ -7,10 +7,6 @@ secrets: runs: using: 'composite' steps: - - uses: pnpm/action-setup@v2 - with: - version: 8 - - name: Set up Node.js uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d #v3.8.1 with: @@ -19,6 +15,9 @@ runs: scope: '@talend' cache: 'pnpm' + - name: Install PNPM + run: npm install -g pnpm@8.9.2 + - name: Get pnpm cache directory path id: pnpm-cache-dir-path shell: bash diff --git a/.github/workflows/pr-playground.yml b/.github/workflows/pr-playground.yml index 130f147da4d..67ad3f473b7 100644 --- a/.github/workflows/pr-playground.yml +++ b/.github/workflows/pr-playground.yml @@ -71,6 +71,9 @@ jobs: - name: Checkout sources uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #v4.0.0 + - name: Use Node.js + uses: ./.github/actions/setup-node + - name: Check UMD files size diff uses: preactjs/compressed-size-action@8119d3d31b6e57b167e09c81dfa877eada3bcb35 #v2.5.0 if: github.ref != 'refs/heads/master' diff --git a/.tool-versions b/.tool-versions index 99f4ccb8896..700063bc5ae 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1 +1,3 @@ -nodejs 20.8.0 +nodejs 20.8.1 +# asdf plugin-add pnpm +pnpm 8.9.2 diff --git a/fork/dynamic-cdn-webpack-plugin/src/find.test.js b/fork/dynamic-cdn-webpack-plugin/src/find.test.js index 86d68f64c48..c2aedba0b99 100644 --- a/fork/dynamic-cdn-webpack-plugin/src/find.test.js +++ b/fork/dynamic-cdn-webpack-plugin/src/find.test.js @@ -32,7 +32,6 @@ describe('findPackages', () => { const result = findPackages(undefined, 'react'); // then - console.log('LIST OF RESULT: ', result); expect(result.length).toBe(2); expect(result[0]).toBe('/node_modules/react'); expect(result[1]).toBe('/node_modules/@talend/react-components/node_modules/react'); diff --git a/package.json b/package.json index 17be2aa3eea..8333fb0ee14 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "webpack": "^5.73.0" }, "scripts": { - "postinstall": "pnpm --sort -r --stream run build:lib", + "postinstall": "pnpm -r --stream run build:lib", "pre-release": "pnpm -r run pre-release", "start": "pnpm --filter @talend/ui-playground run start", "start-storybook": "pnpm --filter @talend/ui-storybook-one run start", @@ -26,7 +26,7 @@ "lint-staged": "lint-staged", "lint": "pnpm -r --no-bail run lint", "lint-merge-report": "pnpm -r lint-merge-report", - "test": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test", + "test": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test --silent", "test:update": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test --silent -u", "test:cov": "cross-env TZ=Europe/Paris pnpm -r --no-bail run test:cov", "test:demo": "pnpm -r --no-bail run test:demo",