Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some TXs signed by the wallet can be reported as successful when they are not #1448

Open
alecdwm opened this issue May 31, 2024 · 0 comments
Open

Some TXs signed by the wallet can be reported as successful when they are not #1448

alecdwm opened this issue May 31, 2024 · 0 comments
Labels
bug A bug

Comments

@alecdwm
Copy link
Member

alecdwm commented May 31, 2024 •
edited
Loading

For at least the following pallets:

  • Batch
  • Proxy
  • Multisig

It is not enough to just check for an extrinsicSuccess event.
It is possible for these TXs to emit a success event, but also fail.

Here's an example of how we do it for the Proxy pallet in Signet.
@alecdwm alecdwm added the bug A bug label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alecdwm