Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onChainId NS -> address cache in wallet #1595

Open
alecdwm opened this issue Sep 3, 2024 · 0 comments
Open

Remove onChainId NS -> address cache in wallet #1595

alecdwm opened this issue Sep 3, 2024 · 0 comments
Assignees
Labels
bug A bug P2 - medium A medium severity issue

Comments

@alecdwm
Copy link
Member

alecdwm commented Sep 3, 2024

We shouldn't cache these - because in cases where the onChainId changes we don't want to keep substituting in the old address.

Related to #960

@alecdwm alecdwm added the bug A bug label Sep 3, 2024
@alecdwm alecdwm self-assigned this Sep 3, 2024
@chidg chidg added the P2 - medium A medium severity issue label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug P2 - medium A medium severity issue
Projects
None yet
Development

No branches or pull requests

2 participants