Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP methods supported by Magpie::Resource are restricted. #4

Open
tobyink opened this issue Aug 13, 2012 · 2 comments
Open

HTTP methods supported by Magpie::Resource are restricted. #4

tobyink opened this issue Aug 13, 2012 · 2 comments
Assignees
@ubu

Comments

@tobyink
Copy link
Member

tobyink commented Aug 13, 2012

Magpie::Dispatcher::RequestMethod limits the list of HTTP methods to those defined by Magpie::Constants.

But others exist... http://annevankesteren.nl/2007/10/http-methods

MGET, MPUT and MDELETE (not on the list above) are also occasionally spoken about in Semantic Web circles.
@ubu
Copy link
Member

ubu commented Nov 22, 2012

I'm certainly open to making those more flexible. The goal is to reliably cover the standard verbs but that doesn't mean it should block more evolved/experimental extensions. Do you have thoughts about how to implement this?

@ghost ghost assigned ubu Nov 22, 2012
@tobyink
Copy link
Member Author

tobyink commented Nov 22, 2012

Making HTTP_METHODS into a package variable rather than a constant would be a start.

perigrin added a commit that referenced this issue Mar 3, 2013
@perigrin
Move Magpie::Constants to Sub::Exporter
baa2ec1 
Magpie::Constants was DIYing an Exporter unneccessarily. This fixes it
to use Sub::Exporter which is already brought in by Moose. This should
close bug #1 reported by tobyink.

Additionally we use some of the more advanced Sub::Exporter features to
allow adding custom HTTP methods beyond the core set defined by the
W3C/IETF.

    use Magpie::Constants extra_http_methods => [qw(FOO BAR BAZ)] };

or

    use Magpie::Constants  HTTP_METHODS => {
                                extra_http_methods => [qw(FOO BAR BAZ)]
                            };

Should both now work. This closes bug #4 reported by tobyink.

Tests are left as a lemma for the reader (currently).
@perigrin perigrin mentioned this issue Mar 3, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ubu ubu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ubu @tobyink