Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ectool and windows support #30

Open
leopoldhub opened this issue May 9, 2024 · 2 comments · May be fixed by #57
Open

ectool and windows support #30

leopoldhub opened this issue May 9, 2024 · 2 comments · May be fixed by #57
Assignees
Labels
enhancement New feature or request

Comments

@leopoldhub
Copy link
Collaborator

leopoldhub commented May 9, 2024

Hi,

In the PR #29 , we replaced Most of the Linux dependencies (replacing the file paths with ectool) except for the sockets.

It should now be possible to adapt the script for windows users.

The ectool can be built for win x64 by reproducing the goal in the .gitlab-ci.yml file (after installing VisualStudio Community 2022 with the C++ and ClangCL package (the installation path may vary slightly))
I have successfully built it in a VM, however since I do not have a native windows installation, I could not fully test if the ectool can properly interacts with the computer hardware.

If you have one, could you please test it on your end, and if everything is ok add the exe to the repo bin folder so I can start the adaptation?

@TamtamHero
Copy link
Owner

Indeed, that would be nice for Windows users but I don't have a Windows install either

@leopoldhub
Copy link
Collaborator Author

I will try to setup one without messing with my existing install then

@leopoldhub leopoldhub self-assigned this May 21, 2024
@leopoldhub leopoldhub added this to the Windows support milestone May 21, 2024
@leopoldhub leopoldhub added the enhancement New feature or request label May 21, 2024
leopoldhub added a commit to leopoldhub/fw-fanctrl that referenced this issue Jul 6, 2024
@leopoldhub leopoldhub linked a pull request Jul 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants