-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[solid-query] Uncaught (in promise) Error: experimental_prefetchInRender feature flag is not enabled #8209
Comments
Note: i can’t access your sandbox - it’s likely set to private. I see no error in the Solid Query Simple example: |
we see this issue too in our setup. (solid-start, without bun) @TkDodo the url in example is pasted 2 times. just copy one of the halves. opens fine here |
StackBlitz link for the same repo: I'm also experiencing the experimental_prefetchInRender feature flag error in my SolidJS project. |
sorry for that i fixed it |
having the same issue, this seems to be happening since |
Can confirm, rolling back to 5.56.2 does not present this. |
@YosefBayoude I rolled back to |
codesandobx still doesn’t work for me, but stackblitz does: https://stackblitz.com/github/BierDav/temp-tanstack-query-ssr-bug/tree/experimental-flag-warning @KATT this promise rejection shows up in the solid-js adapter: query/packages/query-core/src/queryObserver.ts Lines 89 to 93 in 5d69ad7
Not sure why it works for react though 🤔 Is there a better place where we can reject the promise - or should we do it at all? |
@TkDodo have the same issue in React ( |
This is odd, we add a query/packages/query-core/src/thenable.ts Lines 52 to 54 in 06e315c
Can this be a Vite-thing or something? 🤔 |
@vlad99902 I haven’t seen this in react so far - can you make a reproduction for that please? |
This issue doesn't affect react |
Unfortunately it does, i'm seeing it in react.
|
do you have a reproduction? |
any update on this one ? |
Describe the bug
When using the latest version of tanstack-query you get at least in solidjs for each query this error message in the console:
Your minimal, reproducible example
https://codesandbox.io/p/github/BierDav/temp-tanstack-query-ssr-bug/experimental-flag-warning
Steps to reproduce
bun i && bun dev
Expected behavior
No error message in the console, because the
promise
wasn't even accessedHow often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Tanstack Query adapter
solid-query
TanStack Query version
v5.59.13
TypeScript version
No response
Additional context
I have looked into the code. It is not really that something went wrong, and more about that the promise which causes this issue is evaluated even though the feature is not set.
Probably the easiest solution is to replace the promise when the flag is not enable with a
getter
function which then only throws the error, when the promise is really accessed.The text was updated successfully, but these errors were encountered: