Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on week 5 project progress for tanzhanming #4

Open
3 of 4 tasks
nus-se-bot opened this issue Sep 11, 2019 · 1 comment
Open
3 of 4 tasks

Feedback on week 5 project progress for tanzhanming #4

nus-se-bot opened this issue Sep 11, 2019 · 1 comment

Comments

@nus-se-bot
Copy link

nus-se-bot commented Sep 11, 2019

Leftovers from the previous week

  • A version tagged A-Jar is in the repo(:exclamation: try to do by next milestone)

  • You have added comments on at least two PRs(:exclamation: try to do by next milestone)

Progress of this week

  • At least 2 PRs are in your fork(:exclamation: try to do by next milestone)

  • A version tagged C-DetectDuplicates is in the repo(:heavy_check_mark: well done!)

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2019-09-11 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

@TanZhanMing
Copy link
Owner

TanZhanMing commented Sep 14, 2019

At least 2 PRs are in your fork(❗️ try to do by next milestone)
My bad. Did not read instructions clearly enough.

Uh, I commented last week but on the wrong place for Peer Reviews.
I commented at nus-cs2103-AY1920S1#304 instead of
https://github.com/nus-cs2103-AY1920S1/duke/pull/304/files/53fb034d073893a3e05675fbccc200d368cc3e25
My bad. Will fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants