Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the depencies #32

Closed
kbaexpandit opened this issue Feb 19, 2019 · 3 comments
Closed

Reduce the depencies #32

kbaexpandit opened this issue Feb 19, 2019 · 3 comments

Comments

@kbaexpandit
Copy link

kbaexpandit commented Feb 19, 2019

Hi

This is just a suggest/feature request. My company is using this library for our website. We are using webhotels and azure website. In this situation we can't install redistributable c++ 2017 as we don't have access to the machine.

So what I suggest is that the dependency be compiled into the libsass.dll as this will make the solution more portable. Perhaps as another set of dll's if people don't want the static linking.

The only change that needs to happen is set

  <RuntimeLibrary>MultiThreaded</RuntimeLibrary>

in libsass.vcxproj:

  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
    <ClCompile>
      <WarningLevel>Level3</WarningLevel>
      <PrecompiledHeader>
      </PrecompiledHeader>
      <Optimization>MaxSpeed</Optimization>
      <FunctionLevelLinking>true</FunctionLevelLinking>
      <IntrinsicFunctions>true</IntrinsicFunctions>
      <PreprocessorDefinitions>WIN32;NDEBUG;_LIB;$(PreprocessorDefinitions);</PreprocessorDefinitions>
      <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
    </ClCompile>

Thanks in advance

@Taritsyn Taritsyn closed this as completed Mar 2, 2019
@Taritsyn Taritsyn reopened this Mar 2, 2019
@Taritsyn
Copy link
Owner

Taritsyn commented Aug 8, 2019

Hello, Kim!

I did not dare to add this feature for a long time (even conducted a poll), but today I released a new version of the library that contains this functionality.

@kbaexpandit
Copy link
Author

Hi

We have executed with our own compiled version since the creation of the post. It has worked great for us. The only problem we have is that the IIS locks the dll because it a c++ dll, so we can't do hot deployment on those dll. But that is also the only problem we have been seeing. WE have changed our deployment so these dll's aren't part of the ho deployment package and then we are able to archive all that we wanted.

@Taritsyn
Copy link
Owner

Taritsyn commented Aug 9, 2019

The only problem we have is that the IIS locks the dll because it a c++ dll, so we can't do hot deployment on those dll.

This is a known problem and it has been discussed many times (and it is typical not only for the LibSass Host library): “File lock on LibSassHost.Native-64.dll”, “w3wp.exe locks 'libsass*.dll'” and “libsass.dll locked by IIS Worker Process”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants