Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade to v1.3.1 adds /c/ to paths #39

Closed
AndersMad opened this issue May 2, 2020 · 7 comments
Closed

[BUG] Upgrade to v1.3.1 adds /c/ to paths #39

AndersMad opened this issue May 2, 2020 · 7 comments

Comments

@AndersMad
Copy link

AndersMad commented May 2, 2020

I upgraded to v1.3.1 - no other changes and got 404. Doing debug it seems that the path transferred to e.g. IFileManager.FileExists now starts with /c/client/ - I do not know where that c comes from - maybe from the first char in client.

Also some of the paths also go dobbelt slash end /stuff//

@Taritsyn
Copy link
Owner

Taritsyn commented May 2, 2020

Hello, Anders!

In my case, this problem does not occur. Try making a demo project that reproduces this error and send me a link to it.

@AndersMad

This comment has been minimized.

@AndersMad
Copy link
Author

Might be related to sass/libsass#3091 - I'll degrade and see how it pans out.

@AndersMad
Copy link
Author

Found "work around": Add an extra pre-slash to the IFileManager.GetCurrentDirectory() so instead of e.g. /client/ for current dir - return //client/

@Taritsyn
Copy link
Owner

Taritsyn commented May 2, 2020

Found "work around": Add an extra pre-slash to the IFileManager.GetCurrentDirectory() so instead of e.g. /client/ for current dir - return //client/

I would like to see a stylesheet, not a “hack” in the source code.

@mgreter
Copy link

mgreter commented May 4, 2020

This change could be related sass/libsass#3085.
The mentioned issue is pretty certainly not related :)

@AndersMad
Copy link
Author

I didn't mean the glob plugin was the cause just that it might suffer under the same thing :) buy yes, rv.insert(0, cwd, 0, 2) most def is the culprit and line above says my hack (should) work with double slash so I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants