Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems on the links #6

Open
RyckRichards opened this issue Aug 4, 2020 · 4 comments
Open

Problems on the links #6

RyckRichards opened this issue Aug 4, 2020 · 4 comments

Comments

@RyckRichards
Copy link
Member

Doren (driini) reports the following:


I just translated the https://en.wiki.tatoeba.org/articles/show/contribute-audio2## into german: https://de.wiki.tatoeba.org/articles/show/audio_de##
But you can't see the English link at "Article available in:" on my german translated site. So you can't go directly to the existing English version.

She asked if it is because she named it instead of
https://de.wiki.tatoeba.org/articles/show/audioaufnahmen2##
https://de.wiki.tatoeba.org/articles/show/audio_de##

There are only two places which use this address:
https://de.wiki.tatoeba.org/articles/show/audioaufnahmen##
and
https://en.wiki.tatoeba.org/articles/show/contribute-audio2##

@trang
Copy link
Member

trang commented Aug 5, 2020

Note that this is no longer reproducible. I deleted the duplicate articles and fixed the slugs that were created by Doreen.

The issue is that Doreen created two pages with almost the same slug. One with a # and at the end and one without #.

The scenario is (very likely) the following:

  1. Add a translation to an existing page by clicking on "Translate" in the sidebar. Let's say it's a German translation of a English page.
  2. For the slug of the page, enter something with a hashtag at the end, for instance neu-test#.
  3. After saving, you'll be redirected to a blank form to create a new page.

→ Expected behavior: I should be redirected to the translation page.

  1. You think your translation was not saved and enter again the translation, but this time with the slug neu-test. This creates an actual new page instead of a translation.
  2. From the original English page, you click on German in the sidebar, to view the German page.
  3. From the German page, you do not see the possibility to go back to "English". That is because the wiki redirects you to neu-test (the new page) instead of neu-test# (the translation).

→ Expected behavior: the wiki should redirect to the translation and not to the new page.

@jiru
Copy link
Member

jiru commented Aug 9, 2020

Why are these # being appended to wiki URLs all the time anyway?

@trang
Copy link
Member

trang commented Aug 9, 2020

No idea :/

@allan-simon
Copy link

I think there's one function in the javascript that checks the url for the part after the hashtag to do something with it, and as a side effect it does append the # ( if I remember correctly ^^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants