Syncing watchlist between Trakt and Plex always adds back removed items #1247
Comments
|
When there is a Movie in one watchlist but not in the other watchlist, how could the script kow if it should remove it from the first watchlist or add it in the second wtchlist ? |
|
I can't work out the details right now because I don't know how exactly each API works, but it should be possible by keeping some local state for the previous sync for each watchlist, and do some condition checks. Right now, the way it's implemented, it acts more like a "mirror" than a "sync". |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Workaround is to sync watchlist only one-way (plex_to_trakt or trakt_to_plex). |
|
Not really a workaround for me, I have no use for having just one of them enabled. Either 2-way sync works taking into account removed items, or I might as well just turn off both |
Disabled until the following issue is fixed:
- Taxel/PlexTraktSync#1247
Disabled until the following issue is fixed:
- Taxel/PlexTraktSync#1247
|
I noticed the trakt response includes also, trakt side |
|
so, the trakt response has: {'id': 773647533,
'listed_at': '2022-12-07T10:34:20.000Z',
'movie': {'ids': {'imdb': 'tt0070948',
'slug': 'zardoz-1974',
'tmdb': 4923,
'trakt': 2858},
'title': 'Zardoz',
'year': 1974},
'notes': None,
'rank': 8,
'type': 'movie'}but all data that's not inside so would need new data class to pytrakt that has |
|
actually, watchlist_shows would pass the extra data to TVShow: but I guess a new class with extra fields would be a cleaner solution. |
Explain how useful it is please. |
please note the question form of the sentence. the idea was to compare plex side do you see a solution how to do with only two timestamps? something like compare newest entry in plex = last update in plex side, and same for trakt? |
|
@glensc I have a Trakt Pro subscription, and I could make a feature request on the Trakt VIP forums to improve the API to allow this use case, I just need to know the exact requirements. Let me know how I can help. |
Explain how comparing |
You omitted the part where I said sync timestamp is needed. in my mind, the algo would be:
the same for other direction. |
|
yes. this could work def plex_watchlist_updated_at(self):
from datetime import datetime, timezone
from plexapi import utils
updated_at = datetime(1970, 1, 1)
for pm in self.plex_wl.values():
listed_at = utils.toDatetime(pm._data.get("watchlistedAt"))
updated_at = max(updated_at, listed_at)
return updated_at.astimezone(timezone.utc)
def trakt_watchlist_updated_at(self, watchlist):
from datetime import datetime, timezone
updated_at = datetime(1970, 1, 1).astimezone(timezone.utc)
for tm in watchlist.values():
listed_at = datetime.strptime(tm.listed_at, "%Y-%m-%dT%H:%M:%S.%f%z")
updated_at = max(updated_at, listed_at)
return updated_at
def watchlist_sync_item(self, m: Media, dry_run=False):
if not self.sync_wl:
return
plex_watchlist_updated_at = self.plex_watchlist_updated_at()
print(plex_watchlist_updated_at)
trakt_movies_watchlist_updated_at = self.trakt_watchlist_updated_at(self.trakt_wl_movies)
print(trakt_movies_watchlist_updated_at)
if plex_watchlist_updated_at > trakt_movies_watchlist_updated_at:
print(f"Plex watchlist is newer")
else:
print(f"Trakt watchlist is newer") |
|
extra thing to consider:
https://trakt.docs.apiary.io/#reference/sync/get-watchlist/get-watchlist:
could maybe compare "played_on_trakt" state and make an extra decision. |
How do you get it ?
I think those |
read last sentence:
also must consider trakt removes automatically from Watchlist: |
|
Removed automatically or manually from watchlist doesn't change the problem. |
|
Perhaps one thing to do is not to add to watchlist items that are played. |
|
found that trakt offers a response that includes when watchlist was last updated: |
|
This feature would be a great addition as I would like to use the watchlists in this way:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I agree with this! |
Alternatively you could use a script specifically to remove watched items from plex/trakt watchlists. Edit: After thinking about it this would be a great separate feature to add as an optional config setting. I opened a separate issue for it here #1494 |
|
Similar problem to synchronizing two filesystems, that do not know about each other. Take a look at how rclone solved with for the bisync feature: https://rclone.org/bisync/. Subsequent runs can then decide based on timestamp, which items where removed from each list or added to each list and replicate this action to the other list. The only problem with this approach, is that the index needs to be protected. If the local copy of the list with the timestamps is tampered with, lost or in some other way corrupted, chaos can ensue. Worst case is, both lists get pruned of all items. Another failure case is that updates are lost, e.g. all removed items from last run are added back. There is a lot of fun computer sciency topics to think about, e.g. https://en.wikipedia.org/wiki/Write%E2%80%93write_conflict. Don't think implementing this well would be trivial. Or maybe I am overthinking it. |
|
Without adding local database conclusion made already earlier. Some attempts already exists:
Perhaps first step would be add plugin to fill the database using new plugin infrastructure: |
I was thinking about ways you could implement this too and this was my conclusion as well. There is a lot of risk associated with trying to determine which items to delete. Trakt API goes down pretty frequently which can cause issues. Local database can be corrupted, deleted, etc. Sometimes Trakt API can also omit results when things are not working correctly (multiple pagination pages missing). I would assume the same risks for Plex API as well. There would need to be a lot of fail proof checks in order to accomplish this safely. Some things I was considering in one of my projects (IMDB-Trakt-Syncer) that would apply here as well, schedule items to be removed. Periodically check all lists to verify the item should be deleted (to ensure no API errors), after a certain amount of checks or time passed then approve the scheduled items for deletion. Additionally, you could add a check so that if more than 50% of a list is to be deleted then stop the deletion (in order to prevent accidental deletion due to unforeseen issues). As you can see it would get very complicated and there is still risk of chaos ensuing as you mentioned. |
Confirmation
The problem
Syncing my watchlist between Trakt and Plex does not preserve remove state, that is:
Error trace / logs
I removed 3 movies from my Trakt Watchlist and ran
plextraktsync sync --sync=movies:I removed 3 movies from my Plext Watchlist and ran
plextraktsync sync --sync=movies:Expected behavior
Steps to reproduce the behavior
Any sync command results in the issue.
Inspect of problematic items
No response
Workarounds
No response
Install method
docker-compose
Config file contents
Version
0.24.5
Python Version
3.11.0
Operating System and Version
Synology (Linux)
The text was updated successfully, but these errors were encountered: