From ab749c9673e274296a6ad0415c0758628fd1ae43 Mon Sep 17 00:00:00 2001 From: Roman Korostinskiy <70313618+c71n93@users.noreply.github.com> Date: Mon, 19 Feb 2024 20:10:28 +0300 Subject: [PATCH] #54 add todos --- src/ChaiVM/utils/instr2Raw.cpp | 1 + test/ChaiVM/interpreter/executor-test-fixture.hpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/ChaiVM/utils/instr2Raw.cpp b/src/ChaiVM/utils/instr2Raw.cpp index f635224..2a6edff 100644 --- a/src/ChaiVM/utils/instr2Raw.cpp +++ b/src/ChaiVM/utils/instr2Raw.cpp @@ -8,6 +8,7 @@ static uint8_t operation2opcode(Operation operation) { return (uint8_t)operation; } +// @todo #54:60min add template parameter by format and refactor naming chai::bytecode_t instr2Raw(Operation op, RegisterId r1, RegisterId r2) { return (operation2opcode(op)) | (r1 << 8) | (r2 << 16); } diff --git a/test/ChaiVM/interpreter/executor-test-fixture.hpp b/test/ChaiVM/interpreter/executor-test-fixture.hpp index cc908b6..fcb06e4 100644 --- a/test/ChaiVM/interpreter/executor-test-fixture.hpp +++ b/test/ChaiVM/interpreter/executor-test-fixture.hpp @@ -67,6 +67,7 @@ class ExecutorTest : public ::testing::Test { return loadN(op); } + // @todo #54:60min do something to add this functionality to load Immediate void loadWithConst(chai::interpreter::Operation op, int64_t data); void loadWithConst(chai::interpreter::Operation op, double data);