Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua Water not rendering surface texture properly #4

Open
UpcraftLP opened this issue Jun 21, 2018 · 4 comments
Open

Aqua Water not rendering surface texture properly #4

UpcraftLP opened this issue Jun 21, 2018 · 4 comments
Labels
bug Something isn't working forge bug issue with forge itself

Comments

@UpcraftLP
Copy link
Member

UpcraftLP commented Jun 21, 2018

under certain conditions the surface of the aqua water block is not being rendered, even tho it should be visible.

This is a Forge Bug but there's a PR outstanding! (MinecraftForge/MinecraftForge/pull/4763)

@UpcraftLP UpcraftLP added bug Something isn't working wontfix This will not be worked on labels Jun 21, 2018
@sekwah41
Copy link
Collaborator

I will make more checks be performed, this is a cause that I felt for the timeframe was fine. Its not a bug but rather something I purposefully disabled though may change it to reenable in some cases. Without the code that causes this you get the issues.

I will look into using the tessellator to render only one side of the face rather than both when blocks are above to achieve the same effect.

@UpcraftLP UpcraftLP added forge bug issue with forge itself and removed wontfix This will not be worked on labels Jul 27, 2018
@UpcraftLP
Copy link
Member Author

seems like the PR has been merged, however we'll need to see if that solved our problem.

@sekwah41
Copy link
Collaborator

@UpcraftLP remove the no rendering code for the water rendering when pointing up that I added

@UpcraftLP
Copy link
Member Author

@sekwah41 tried that but it doesn't work quite well. it's not on top of our priority list but if you want you can try fix it.

@sekwah41 sekwah41 removed their assignment Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forge bug issue with forge itself
Projects
None yet
Development

No branches or pull requests

2 participants