Skip to content

Commit 417c8c8

Browse files
committed
forget about differnt clang versions -- lets just assume we need only Wno-vla-extension
1 parent 412256e commit 417c8c8

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

src/Makefile

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -91,26 +91,16 @@ ifneq ($(filter fast staticfast,$(MAKECMDGOALS)),)
9191
endif
9292

9393

94-
### Suppress specific warnings for clang
95-
COMPILER_NAME := $(shell $(CPP) --version | head -n 1)
96-
ifeq ($(findstring clang,$(COMPILER_NAME)),clang)
97-
CLANG_VERSION_MAJOR := $(shell $(CPP) -dumpversion | cut -d. -f1)
98-
ifneq (,$(filter $(CLANG_VERSION_MAJOR),17 18 19 20))
99-
CLANG_VLA_FLAG := -Wno-vla-cxx-extension
100-
else
101-
CLANG_VLA_FLAG := -Wno-vla-extension
102-
endif
103-
endif
104-
10594
EXTRA_WARN_SUPPRESS := \
95+
-Wno-vla-extension \ # might need -Wno-vla-cxx-extension for clang>18?
10696
-Wno-unused-parameter \
10797
-Wno-unused-variable \
10898
-Wno-sign-compare \
10999
-Wno-reorder-ctor \
110100
-Wno-unused-function
111101

112102

113-
CXXFLAGS := -std=c++17 -Wall $(OPTFLAGS) $(CXXFLAGS_SPECIFIC) $(CLANG_VLA_FLAG) $(EXTRA_WARN_SUPPRESS)
103+
CXXFLAGS := -std=c++17 -Wall $(OPTFLAGS) $(CXXFLAGS_SPECIFIC) $(EXTRA_WARN_SUPPRESS)
114104
ICFLAGS := -I$(GSLINCDIR) -I$(BOOSTINCDIR) -I$(HDF5INCDIR) -I.
115105

116106
LIBS := -lm -lz -ldl -lpthread

0 commit comments

Comments
 (0)