SFM 4.20.0 release progress

[TeamDman]

Changelog at the time of creating this post:

SuperFactoryManager/src/main/resources/assets/sfm/template_programs/changelog.sfml

Lines 7 to 36 in cf518b8

	---- 4.20.0-pre ----
	-- Fix disks having no name when program has no name for 1.21+
	-- VSCode extension updates, thanks @Titop54 for the help <3
	-- Fix max program length ungraceful crash, thanks @Crazy
	---- Set MAX_PROGRAM_LENGTH to ~32,300 because of vanilla constraints
	-- Renamed resource types example to include "fluid" in the title
	-- Add edit-in-hand reminder text to disk when no program present
	-- Add reminder to push labels when warnings present
	-- Optimize EACH limits
	EVERY 20 TICKS DO
	INPUT FROM chest
	OUTPUT RETAIN 1 EACH *seed* TO phyto
	-- this no longer lags the more items match lol
	END
	-- Add support for OR
	EVERY 20 TICKS DO
	INPUT
	5 stone OR dirt, -- move 5 total (stone|dirt)
	cobblestone -- move all cobble
	FROM chest
	END
	-- Fix correctness bug
	---- With multiple 'b' inventories, each one would keep 5 instead of 5 across them total
	EVERY 20 TICKS DO
	input retain 5 from b
	output to a
	END
	-- Update round robin example to advocate for using "retain" instead
	-- Add notice to inspector that slot numbers may not correspond with automation slots

Additionally, there is some more to be done before the release goes live.

I have merged some pull requests that need some massaging to fit better into codebase.

Fancy inventory cables

• Validate functionality
• Add to changelog
• Revert rename of cable => cable_block since we don't want to break existing builds
• Add uncrafting recipe

Resource type disallow config

• Backport
• Validate functionality
• Add to changelog

Manager view server config button

• Implement S2C packet - open text editor gui showing toml view of sfm config - tick limits and disallowed resource types
• Implement manager button to C2S request to receive S2C packet
• Implement slash command to request to receive S2C packet
• Implement C2S packet - op to update config
• Add to changelog

Paste from clipboard confirmation dialog

• Implement
• Add to changelog

Network Tool, Label Gun rendering optimization

• Backport
• Validate functionality
• Add to changelog

Label gun show-only-selected toggle

• Backport
• Validate functionality
• Add to changelog
• Reposition button
• Implement reminder overlay
• Implement toggle key

Label gun pick-block to clone label

• Implement
• Add tooltip reminder text
• Add to changelog

Label gun gui searching

• Backport
• Validate functionality
• Add to changelog
• Ensure manual label entering functionality still present

Cable facades

• Backport
• Validate functionality
• Add to changelog
• Add documentation via network tool tooltip
• Migrate to separate block to fix pistons
• Verify piston functionality
• Verify cable_facade block drops cable block item when broken

WITH logic (parentheses, negation, conj, disj)

• Add to changelog
• Add game tests

TestBarrelTank

• Add test using new TestBarrelTank for [BUG] Round Robin selecting different targets in same operation #166
• Convert existing tests to use new TestBarrelTank
• (optional) Promote to fully featured block

Printing Press Crash

• Reproduce
• Fix
  https://discord.com/channels/254530689225981953/1236826820200894496/1302308788358873163

Optimize endBatch

• Investigate

IMS — Today at 12:57 PM
don't call endBatch
that command is basically a call to render literally everything before you instantly

https://discord.com/channels/254530689225981953/1202015348765753344/1302315663099953263

Turns out still needed in older MC versions that SFM supports.

EVERY 20n+1 TICKS, EVERY 20g+1 TICKS

• Implement
• Add to changelog

Cable piston interactions

• Verify
• Add to changelog

Fix code ctrl+space action on label containing too many items causing crash

• Introduce truncation
• Add to changelog

Add timeout config for auto-disabling managers

• Implement watchdog
• Implement commenting-out-program-to-disable-with-comment
• Change default minimum tick interval to 1 from 20?
• Add to changelog

Final touches

• Forward-propagate all changes
• Low-hanging fruit github issues
• Warn when using mekanism blocks with null side
• Optimize performance using profiler to identify inefficient code
• Record changelog video and add to changelog
• Build jars, manual test each MC version on local server, and upload to CurseForge and Modrinth

[TeamDman]

Backporting 'successful' because no compile errors. May have simply missed some stuff. Haven't checked if most of it works.
Rendering optimization for the label gun and network tool is huge, getting no performance drop instead of being dropped to like 14fps lol

[TeamDman]

https://discord.com/channels/967118679370264627/967119184209264790/1304232953555058718

• Fix false positives in warnings

[TeamDman]

unable to reproduce

[TeamDman]

attempting a fix without reproduction by fixing

fix simulation starting when exceeding configured max branches, should never start

87fd6ad

[TeamDman]

• Fix scrollbar offset problem

[TeamDman]

• Disable slot pool validators in production (and in dev behind a flag)

[TeamDman]

• Reduce allocations by changing some usages of Set to ArrayList or something

[TeamDman]

• Fix gui blur thing

[TeamDman]

Fixed by Neoforge, see #165

[TeamDman]

• Label gun next/previous dedicated button because people have broken scrollwheels 😩

[TeamDman]

• Facade fancy cables?

[TeamDman]

• Network tool show all sides right click

[TeamDman]

• Network tool fix missing line endings when multiple resource types present in block

[TeamDman]

• Increase detail in RESOURCE LOSS report

• Slot source location, block, block entity, class

• Slot destination location, block, block entity, class

• Stack withdrawn

• Stack inserted

• Stack remaining

[TeamDman]

• Clamp moveTo logic to MAX_INT - 128 to avoid integer overflows from erroneous mod logic

Reported an integer overflow to CoFH
https://discord.com/channels/399037120930512897/434101214548852746/1306494699758157824

[TeamDman]

• Add config to disable RESOURCE LOSS warnings in the server console for server owners lol

[TeamDman]

• Label gun craft-to-clear
• Label gun clear gui button to reset active label

[TeamDman]

• Remove battery block or at least fix warnings Exception loading blockstate definition #194

[TeamDman]

• add test for cofh resource loss error regression, set manager log level to error and assert that logger is empty afterwards

[TeamDman]

• Add advancements

[TeamDman]

• Fix xp shards

[TeamDman]

• Fix tests being flaky

Getting "Test didn't complete in 100 ticks" messages.

My hypothesis is that the xp_shard_many test, which edits the config, is causing a config revision bump which tells the managers to rebuild their programs a tick after the test monkey patches the manager program to check the end condition of the test.

Preventing the manager program from rebuilding during a test should fix this if this hypothesis is correct.

[TeamDman]

• Add label cleanup pruning when not detected as valid inventory