-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Manager stops working #140
Comments
TODO: test the rebuild button to make sure it fixes it like how replacing the cables fixes it. I believe this bug is due to some modded inventories not invalidating their capabilities when the chunk is unloaded. BiggerSeries/BiggerReactors#98 This causes SFM's capability cache to retain references to objects that have since been abandoned by their tile entity. SuperFactoryManager/src/main/java/ca/teamdman/sfm/common/cablenetwork/CapabilityCache.java Line 101 in 0b3faec
Here is a situation where BigReactors isn't invalidating the capability, leading to SFM being unable to draw energy after rejoining a server. java_capVjFDemZ.mp4This theoretically could lead to undetectable item loss, where the source inventory is properly invalidated and restored but the destination is not invalidated leading to items being deposited into a handler that isn't the one that doesn't save its changes. SFM does try and detect situations where it accidentally voids items, but when the capability itself is rotten this probably won't help.
It should be possible for SFM to listen to chunk unload events to manually purge the cache. If I can get the chunk unload event handler to happen after Could also make it so that breaking a manager block invalidates the cable network, since people probably expect replacing the manager to fix problems. |
Some lines from the logs of a player who was hitting this issue
In this case, the power tap energy handler is reporting |
This update includes the fix for #140
When I leave the server and come back it stops working until I break and replace cables.
The text was updated successfully, but these errors were encountered: