Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: opening a disk just shows me the blur instead of a gui #165

Open
TeamDman opened this issue Sep 8, 2024 · 4 comments
Open

bug: opening a disk just shows me the blur instead of a gui #165

TeamDman opened this issue Sep 8, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@TeamDman
Copy link
Owner

TeamDman commented Sep 8, 2024

This is an ATM10 problem

@TeamDman TeamDman converted this from a draft issue Sep 8, 2024
@TeamDman
Copy link
Owner Author

TeamDman commented Sep 8, 2024

This is caused by neoforged/NeoForge#1400

@TeamDman
Copy link
Owner Author

TeamDman commented Sep 8, 2024

This is caused by neoforged/NeoForge#1504

@TeamDman
Copy link
Owner Author

TeamDman commented Nov 2, 2024

XFactHD — 09/05/2024 3:41 PM
You are effectively rendering the blurred background twice, once through the this.renderBackground() call and once through the super.render() call. Either that or the z-axis scaling might be the cause. My suggestion would be to replace the renderAfterScale() call with a super.render() call in render() and doing your scaled rendering in renderBackground() after a super call and remove the super.renderCall() from the code that's currently in renderAfterScale(). Additionally, I would recommend removing the z-axis scaling (i.e. set it to 1)
link

looks like this was changed between 1.20.1 and 1.20.2

image

I don't think the drawing of the background twice would be a culprit given the other neoforged issues indicating z-clipping being the problem, but I won't rule it out until I test it.

Agreed that SFM shouldn't call the renderBackground twice, will see what it takes to make the version difference transparent between branches.

The true fix is neoforged/NeoForge#1555 getting merged, until then will see if I can make it work

@TeamDman TeamDman self-assigned this Nov 2, 2024
@TeamDman TeamDman added the bug Something isn't working label Nov 2, 2024
@TeamDman
Copy link
Owner Author

TeamDman commented Dec 6, 2024

This should be fixed with NeoForge 21.1.84 via neoforged/NeoForge#1741

Haven't verified that the fix works yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 💭Brewing ideas
Development

No branches or pull requests

1 participant