Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug | gameplay]双押提示无法完全关闭 #85

Open
point32 opened this issue Jun 6, 2023 · 3 comments
Open

[bug | gameplay]双押提示无法完全关闭 #85

point32 opened this issue Jun 6, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@point32
Copy link

point32 commented Jun 6, 2023

在关闭双押提示后,构成双押的note仍然被放大

@Mivik
Copy link
Contributor

Mivik commented Jul 1, 2023

能详细说明吗?

@point32
Copy link
Author

point32 commented Jul 1, 2023

/phira-main/prpr/src/core/note.rs
第189行~193行
let scale = (if self.multiple_hint {
^^^缺少条件,应保持与211行的 if self.multiple_hint && res.config.double_hint 一致
res.res_pack.note.style_mh.click.width() / res.res_pack.note_style.click.width()
} else {
1.0
}) * res.note_width;

@point32
Copy link
Author

point32 commented Jul 1, 2023

Phira 00 00 04
下边三押和上面的两个note大小明显不同

@sjfhsjfh sjfhsjfh added bug Something isn't working help wanted Extra attention is needed labels Jul 1, 2023
sjfhsjfh added a commit that referenced this issue Feb 27, 2024
@sjfhsjfh sjfhsjfh changed the title 双押提示无法完全关闭 [bug | gameplay]双押提示无法完全关闭 Mar 30, 2024
sjfhsjfh added a commit that referenced this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants