Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find throttling deobfuscation function #1252

Open
6 tasks done
gechoto opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1253
Open
6 tasks done

Could not find throttling deobfuscation function #1252

gechoto opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1253
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/

Comments

@gechoto
Copy link

gechoto commented Dec 24, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I am aware that this issue is being opened for the NewPipe Extractor, NOT the app, and my bug report will be dismissed otherwise.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.3

Steps to reproduce the bug

Call YoutubeJavaScriptPlayerManager.getUrlWithThrottlingParameterDeobfuscated

Expected behavior

It should return the url with the deobfuscated throttling parameter

Actual behavior

It throws a ParsingException

Screenshots/Screen recordings

No response

Logs

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not find deobfuscation function with any of the known patterns in the base JavaScript player code
    at org.schabi.newpipe.extractor.services.youtube.YoutubeThrottlingParameterUtils.getDeobfuscationFunctionName(YoutubeThrottlingParameterUtils.java:134)
    at org.schabi.newpipe.extractor.services.youtube.YoutubeJavaScriptPlayerManager.getUrlWithThrottlingParameterDeobfuscated(YoutubeJavaScriptPlayerManager.java:242)
    ...
Caused by: org.schabi.newpipe.extractor.utils.Parser$RegexException: Failed to find pattern "[a-zA-Z0-9$_]="nn"\[\+[a-zA-Z0-9$_]+\.[a-zA-Z0-9$_]+],[a-zA-Z0-9$_]+\([a-zA-Z0-9$_]+\),[a-zA-Z0-9$_]+=[a-zA-Z0-9$_]+\.[a-zA-Z0-9$_]+\[[a-zA-Z0-9$_]+]\|\|null\).+\|\|([a-zA-Z0-9$_]+)\(""\)"
    at org.schabi.newpipe.extractor.utils.Parser.matchMultiplePatterns(Parser.java:96)
    at org.schabi.newpipe.extractor.services.youtube.YoutubeThrottlingParameterUtils.getDeobfuscationFunctionName(YoutubeThrottlingParameterUtils.java:131)
    at org.schabi.newpipe.extractor.services.youtube.YoutubeJavaScriptPlayerManager.getUrlWithThrottlingParameterDeobfuscated(YoutubeJavaScriptPlayerManager.java:242) 
    ...

Additional information

No response

@gechoto
Copy link
Author

gechoto commented Dec 27, 2024

after updating the regex the new function will also need some fixup, example:
yt-dlp/yt-dlp@a95ee6d#diff-b7b9f6790de4427214b61939432e667d95b929d07fd918b9da1a36d7996cc506R3250

@gechoto
Copy link
Author

gechoto commented Dec 29, 2024

Made a PR which fixes it: #1253

@ShareASmile ShareASmile added the youtube service, https://www.youtube.com/ label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants