Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility concerns with FerriteCore #27

Open
UnassumingTroll opened this issue Jan 28, 2021 · 3 comments
Open

Compatibility concerns with FerriteCore #27

UnassumingTroll opened this issue Jan 28, 2021 · 3 comments

Comments

@UnassumingTroll
Copy link

I found the culprit for the annoying hs_err_pid rendering crash that some people have been experiencing.
Large modpacks have been including an Optifine like mod called FerriteCore https://www.curseforge.com/minecraft/mc-mods/ferritecore that is supposed to reduce the amount of ram a modpack uses, but it's interfering with how UMC mods writes save data (mostly via FTB backups and the usual autosave).

@malte0811
Copy link

I'm looking into this, I would suggest using malte0811/FerriteCore#3 for further discussion (unless you would prefer to keep it here?).
IMO "Optifine-like" is not really a fair description of FerriteCore. Yes, it does optimizations (of memory usage rather than framerate), but that's pretty much the end of "Optifine-like": It is open-source (MIT license), it is designed to be 100% compatible, and I intend to PR at least some of the changes to Forge.
I don't see how it would cause this crash (yet), and I have not managed to reproduce it yet either. Since this seems to be a known crash on this side maybe you can give some information on that? The description that it's related to "how UMC writes save data" does not match the crash either, which is in GL texture upload code.

@UnassumingTroll
Copy link
Author

The latest version of the ATM6 and Direwolf20 modpacks both include FerriteCore, If you install Immersive Railroading and play around for a bit, as soon as Minecraft clears it's GC before it autosaves AND you have trains present or if you have Immersive Railroading highlighted in JEI, the game hard crashes to desktop only to present that mysterious hs_err_pid log file.

I even created my own modpack to test for this error but found nothing wrong with my pack, until I installed FerriteCore, then did I start seeing the exact same hard crashing. Then I decided to confirm my suspicions by disabling FerriteCore in ATM6 and shure enough there is no problems to be had.

If your wondering about the "stand alone IR" crash, that's because I was testing IR with shader's enabled and had no idea that the same thing happens with the current build of UMC, at that point in my testing I had no Idea that it was a mod conflict (I'll update my post to reflect that).

I'm sorry that I can't be of any more help, I'm not a dev, I just inhabit the IR Discord. Perhaps you could swing on by and ask a developer there or just msg cam72cam.

@malte0811
Copy link

I'm still unable to reproduce this, and while your test in TeamOpenIndustry/ImmersiveRailroading#897 apparently included FerriteCore, the original post did not, unless they uploaded a latest.log from a different pack for some reason. The code involved (GLTexture) seems to have at least theoretical threading issues, I'm not sure if they are related to this. It is also (as far as I can tell) pretty much fully independent from anything FC touches, so I'm essentially stuck without some further input (additional required mod, something resembling a reliable test case, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants