Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Overworld Spawn #617

Closed
Darkosto opened this issue Sep 7, 2018 · 8 comments
Closed

Portal Overworld Spawn #617

Darkosto opened this issue Sep 7, 2018 · 8 comments
Assignees

Comments

@Darkosto
Copy link

Darkosto commented Sep 7, 2018

Forge version: 2760
Twilight Forest version: 3.8.654

Steps to reproduce:

  1. Create TF portal in OW
  2. Go to TF
  3. Come back and you will be in a new portal location despite having a valid original portal

What I expected to happen: To use my original portal (to note, this is a much worse issue because of Skylight Forest since you are in the void far from your base)

Thank you! Take care!
DarkSolo

@bs2609
Copy link
Member

bs2609 commented Sep 9, 2018

If it's available the debug.log file from when you were teleporting would be helpful - in particular, I'd like to know if any of these messages show up:

if (!isSafeAround(pos, entity, checkProgression)) {
TwilightForestMod.LOGGER.debug("Portal destination looks unsafe, rerouting!");
BlockPos safeCoords = findSafeCoords(200, pos, entity, checkProgression);
if (safeCoords != null) {
entity.setLocationAndAngles(safeCoords.getX(), entity.posY, safeCoords.getZ(), 90.0F, 0.0F);
TwilightForestMod.LOGGER.debug("Safely rerouted!");
} else {
TwilightForestMod.LOGGER.debug("Did not find a safe spot at first try, trying again with longer range.");
safeCoords = findSafeCoords(400, pos, entity, checkProgression);
if (safeCoords != null) {
entity.setLocationAndAngles(safeCoords.getX(), entity.posY, safeCoords.getZ(), 90.0F, 0.0F);
TwilightForestMod.LOGGER.debug("Safely rerouted to long range portal. Return trip not guaranteed.");
} else {
TwilightForestMod.LOGGER.debug("Did not find a safe spot.");
}
}
}

In addition, doing the following would also be useful:

  1. Go into creative and hover above your original overworld portal.
  2. Run the command /forge setdim @p 7 (or whatever the TF dimension ID is here)
  3. Give yourself a blank magic map and open it.

What does that area look like on the map? (where a non-relocated portal would end up)

@ranger135xp
Copy link

For me, Forge 2772
TF: 3.8.689

Issue happens to me as well.
Followed suggested command and got here:
image

@bs2609 bs2609 self-assigned this Dec 2, 2018
@bs2609
Copy link
Member

bs2609 commented Jan 17, 2019

Generally, this is due to the "entry" portal pointing to an area which is unsafe, as can be seen on the magic map following a direct teleport with commands.

If the first safe point that can be found is too far away from the original entry point, the portal will be unable to link back.

For the case of void worlds where the original portal may not be easily accessible e4e8d51 adds a config option checkPortalDestination which will cause portals to fail to form if the original destination is unsafe. This requires searching for a "safe" portal spot manually, but should ensure a successful return trip.

@ranger135xp
Copy link

I wonder if this is an incompatibility or an issue caused by the mod NetherPortalFix as it appears to change something with portals.

@Darkosto
Copy link
Author

I do not use NetherPortalFix and still have the issue occur in my packs.

@ranger135xp
Copy link

ranger135xp commented Jan 20, 2019

My mistake, I thought that mod was in SevTech.
I'm using a modified FTB Revelation pack, which I think included NPF.

I now have Forge 14.23.5.2807 and TF 3.8.689

@drewkeating
Copy link

This exact issue is happening with the "Dungeons, Dragons and Space Shuttles" mod pack, version 7.4a, which uses twilightforest-1.12.2-3.10.1013-universal

@GizmoTheMoonPig
Copy link
Member

redirecting this to #1459 so we can keep track of every portal issue in 1 place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants