Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Structure #22

Open
mohamednajiub opened this issue Nov 19, 2019 · 1 comment
Open

Website Structure #22

mohamednajiub opened this issue Nov 19, 2019 · 1 comment
Assignees
Labels
invalid This doesn't seem right

Comments

@mohamednajiub
Copy link
Member

Hi @Islam888 @MOhammedRiaad @elharony ,
I noticed that you but the assets "image you use" in docs in website>static>images, and that's not valid for 2 reasons:

  • there is another folder in same directory called img.
  • this assets is relative to docs directory not to website directory.
    so, we need to move website>static>images to docs>images and re-link the image with the new path

suggestion:
rename the folder from images to assets that might take another type of media later.

@mohamednajiub mohamednajiub added the invalid This doesn't seem right label Nov 19, 2019
@elharony
Copy link
Member

Thanks for pointing this out!

I suggest creating a sub-folder inside the website/docs, called assets and put any docs-related images there!

@elharony elharony self-assigned this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants