Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify test suite code to be more generic #316

Open
slifty opened this issue Feb 6, 2020 · 1 comment
Open

Modify test suite code to be more generic #316

slifty opened this issue Feb 6, 2020 · 1 comment
Assignees

Comments

@slifty
Copy link
Contributor

slifty commented Feb 6, 2020

We wrote a test suite generation script for the CNN scrape util pipeline; the concept was that you could specify a url and it would create unit tests for each step of the pipeline for processing that URL.

This concept would also be useful to apply to other areas of the code (e.g. the twitter scrape pipeline, or even the scraper components themselves). It was written as a bit of an R&D concept, so not well organized or engineered. There is an issue for maybe breaking it into an npm module (#315) but in the mean time a smaller step would be to simply make the code more generic / put it into a util of its own.

@slifty
Copy link
Contributor Author

slifty commented Feb 6, 2020

We should also think about how this all compares to Jest snapshots. There isn't an exact overlap, but any refactoring should probably invoke snapshots where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant