Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when --min-changeset is after a branch was created that is merging back #14

Open
jnm2 opened this issue May 7, 2023 · 0 comments
Open

Improve error message when --min-changeset is after a branch was created that is merging back #14

jnm2 opened this issue May 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jnm2
Copy link
Member

jnm2 commented May 7, 2023

Currently throws InvalidOperationException "Should not be reachable. Earlier code should have sorted topologically or failed." rather than validating (possibly before starting) and explaining to the user which --min-changeset they should actually use.

Alternatively to improving the error message, this behavior could be implemented so that the repo has multiple unrelated root commits.
@jnm2 jnm2 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnm2