-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loading with requirejs cause error #58
Comments
What's spitting out the error message? I'm not familiar with requirejs I'm not sure what would cause the issue. Are there any more details in the error message? Can you get requirejs to give you a more verbose error message? Duplicate ooyala/html5-skin#730 |
I'm guessing it has something to do with deepmerge using the UMD pattern so that the module works with the browser, CommonJS, and AMD. But then it's getting bundled in a CommonJS environment in html5-skin, and then you try to load the whole thing from an AMD environment. |
Yh, i think thats the issue. I have tried all possible way. but no luck. the exact error i get is deepmerge is not a function. |
Maybe we should put the actual code in its own file, and bundle a "dist" version with the UMD pattern for publishing. Then we could add That way, bundlers wouldn't pull in the UMD pattern with the rest of the code. Any thoughts? |
yes, we could give it a try. |
The bundler changes were published in 1.4.0. |
Trying to use html5-skin project (https://github.com/ooyala/html5-skin ) which has dependency of deepmerge.
When loading html5-skin via requirejs, it causes
Mismatched
anonymous define() module: function ()`Is there anything i need to do to use this library via requirejs...
It works fine when loading wihtout requirejs..
The text was updated successfully, but these errors were encountered: