From 8d673a8e90e684b9f948fe3c22bd149e62dda35d Mon Sep 17 00:00:00 2001
From: Carsten Schafer <Carsten.Schafer@kinarasystems.com>
Date: Mon, 10 Jun 2024 14:50:15 -0400
Subject: [PATCH] Document some OWLS tuning and try to fix GH issues

Signed-off-by: Carsten Schafer <Carsten.Schafer@kinarasystems.com>
---
 .github/workflows/git-release.yml             |  4 +--
 .github/workflows/release.yml                 | 10 +++----
 .../values.openwifi-qa.owls-external.yaml     | 30 +++++++++++++++++--
 ...values.openwifi-qa.single-external-db.yaml |  6 +++-
 4 files changed, 40 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/git-release.yml b/.github/workflows/git-release.yml
index 4bd3894..1a47c93 100644
--- a/.github/workflows/git-release.yml
+++ b/.github/workflows/git-release.yml
@@ -36,7 +36,7 @@ jobs:
       run: |
         pip3 install yq
         helm plugin install https://github.com/databus23/helm-diff
-        helm plugin install https://github.com/aslafy-z/helm-git
+        helm plugin install https://github.com/aslafy-z/helm-git --version 0.16.0
         ls ~/.local/share/helm/plugins/helm-git/helm-git-plugin.sh || true
         sed 's/--skip-refresh //' -i ~/.local/share/helm/plugins/helm-git/helm-git-plugin.sh
 
@@ -54,6 +54,6 @@ jobs:
         git config --global credential.helper store
         git config --global user.email "tip-automation@telecominfraproject.com"
         git config --global user.name "TIP Automation User"
-        helm repo add bitnami https://charts.bitnami.com/bitnami
+        #helm repo add bitnami https://charts.bitnami.com/bitnami
         helm repo update
         ./git-release-tool.sh
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index d0d3535..a54eff6 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -11,7 +11,7 @@ defaults:
 
 jobs:
   helm-package:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     env:
       HELM_REPO_URL: https://tip.jfrog.io/artifactory/tip-wlan-cloud-ucentral-helm/
       HELM_REPO_USERNAME: ucentral
@@ -42,8 +42,8 @@ jobs:
       - name: Build package
         working-directory: wlan-cloud-ucentral-deploy/chart
         run: |
-          helm plugin install https://github.com/aslafy-z/helm-git --version 0.10.0
-          helm repo add bitnami https://charts.bitnami.com/bitnami
+          helm plugin install https://github.com/aslafy-z/helm-git --version 0.16.0
+          #helm repo add bitnami https://charts.bitnami.com/bitnami
           helm repo update
           helm dependency update
           mkdir dist
@@ -70,7 +70,7 @@ jobs:
           cat Chart.yaml | yq -r '.dependencies[] | "\(.name) - \(.repository) v\(.version)"' >> release.txt
 
       - name: Create GitHub release
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
         with:
           body_path: wlan-cloud-ucentral-deploy/chart/release.txt
           files: wlan-cloud-ucentral-deploy/chart/dist/*
@@ -80,7 +80,7 @@ jobs:
     needs: helm-package
     steps:
     - name: Trigger testing of release
-      uses: peter-evans/repository-dispatch@v1
+      uses: peter-evans/repository-dispatch@v3
       with:
         token: ${{ secrets.WLAN_TESTING_PAT }}
         repository: Telecominfraproject/wlan-testing
diff --git a/chart/environment-values/values.openwifi-qa.owls-external.yaml b/chart/environment-values/values.openwifi-qa.owls-external.yaml
index 258f5f3..1fa726d 100644
--- a/chart/environment-values/values.openwifi-qa.owls-external.yaml
+++ b/chart/environment-values/values.openwifi-qa.owls-external.yaml
@@ -16,8 +16,17 @@ owgw:
     #simulatorid: 53494D020202
     # on a host with more CPUs you may need to bump this up from default of 64
     storage.type.postgresql.maxsessions: 120
-    # this actually disables websocket logging
-    logging.websocket = true
+    # this actually disables websocket logging:
+    logging.websocket: true
+    # consider lowering the # of days to keep archives in the database
+    #archiver.db.0.name = healthchecks
+    #archiver.db.0.keep = 1
+    #archiver.db.1.name = statistics
+    #archiver.db.1.keep = 1
+    #archiver.db.2.name = devicelogs
+    #archiver.db.2.keep = 1
+    #archiver.db.3.name = commandlist
+    #archiver.db.3.keep = 1
 
   resources:
     requests:
@@ -26,3 +35,20 @@ owgw:
     limits:
       cpu: 2000m
       memory: 5Gi
+
+# Postgres tuning for larger # of APs
+#postgresql:
+#  primary:
+#    resourcesPreset: large
+#    persistence:
+#      size: 120Gi
+
+owprov:
+  # consider providing more memory to owprov
+  resources:
+    requests:
+      cpu: 10m
+      memory: 20Mi
+    limits:
+      cpu: 100m
+      memory: 4Gi
diff --git a/chart/environment-values/values.openwifi-qa.single-external-db.yaml b/chart/environment-values/values.openwifi-qa.single-external-db.yaml
index dba82dd..818ddd7 100644
--- a/chart/environment-values/values.openwifi-qa.single-external-db.yaml
+++ b/chart/environment-values/values.openwifi-qa.single-external-db.yaml
@@ -61,12 +61,16 @@ postgresql:
   auth:
     postgresPassword: postgres
   primary:
+    # Consider using this resource model for small installations
+    #resourcesPreset: medium
     extendedConfiguration: |-
       max_connections = 550
       shared_buffers = 128MB
-    #  log_error_verbosity = verbose
     initdb:
       scriptsSecret: tip-openwifi-initdb-scripts
+    # Consider using this disk size for small installations
+    #persistence:
+    #  size: 30Gi
 
 postgresql-ha:
   enabled: false