Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT shouldn't be inited during auction #66

Open
tvorogme opened this issue Oct 25, 2022 · 4 comments
Open

NFT shouldn't be inited during auction #66

tvorogme opened this issue Oct 25, 2022 · 4 comments

Comments

@tvorogme
Copy link

tvorogme commented Oct 25, 2022

According to standard in get_nft_data - init? - if not zero, then this NFT is fully initialized and ready for interaction., but if it's in auction state it's not ready for interaction, I guess? Because transfer is blocked while auction cell is not null

if (~ cell_null?(auction)) {

https://github.com/TelegramMessenger/telemint/blob/main/func/nft-item.fc#L281

tvorogme added a commit to tvorogme/telemint that referenced this issue Oct 25, 2022
@arseny30
Copy link
Collaborator

It is unclear from the standard what the desired behavior is. The nft itself is initialized. It has content. It even will respond to get_static_data.
For example, this smart contract almost always returns -1.

@tvorogme
Copy link
Author

tvorogme commented Oct 25, 2022

Sure, but as for backends (as I think) it'll much easier to run one get method, to know can we use NFTs in our dApps or not.

All dApps uses transfer method to interact with it: any games, marketplaces, etc.

It's sad, that official DNS contract have such behavior, but I personally think that we don't need to populate such behavior further.

@tvorogme
Copy link
Author

tvorogme commented Oct 25, 2022

Otherwise, you will have to download every time NFT data&code and run TVM to check the transfers locally to see if you can use them in your apps or not. This is very uncomfortable, as for me, you'll need to adapt to each NFT instead trust one bit in GET method 🤷‍♂️

@tvorogme tvorogme reopened this Oct 25, 2022
@EmelyanenkoK
Copy link

EmelyanenkoK commented Oct 25, 2022

I don't think it's a problem to show an NFT as initiated when it's actually initiated but hasn't found its owner yet. This shouldn't create a problem since no one can transfer this NFT anyway.

But what about secondary auctions? NFTs cannot be transferred, but get_nft_data does not give any hint of this (thus wallets will not properly handle this situation by default). Maybe it makes sense to show NFT owner as zero_address when the auction is active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants