Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cactus-emitted warnings and errors should go to stderr as well as to the log file #48

Open
jonathanl-telenav opened this issue Aug 24, 2022 · 3 comments
Assignees
Milestone

Comments

@jonathanl-telenav
Copy link
Contributor

When cactus redirects output to the temporary folder log file, it loses important information. For example, the messages below should really go to both the log file and standard error (or standard out), because the invocation seems to succeed otherwise, when it actually did nothing.

[INFO] --- cactus-maven-plugin:1.5.24:git-pull-request (default-cli) @ telenav-build ---
[INFO] Ignoring matched checkout cactus for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout cactus-assets for pull request - because we are matching the branch feature/testing but it is on the branch publish
[INFO] Ignoring matched checkout kivakit for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout kivakit-assets for pull request - because we are matching the branch feature/testing but it is on the branch publish
[INFO] Ignoring matched checkout kivakit-examples for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout kivakit-extensions for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout kivakit-stuff for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout lexakai for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout lexakai-annotations for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout lexakai-assets for pull request - because we are matching the branch feature/testing but it is on the branch publish
[INFO] Ignoring matched checkout mesakit for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout mesakit-assets for pull request - because we are matching the branch feature/testing but it is on the branch publish
[INFO] Ignoring matched checkout mesakit-examples for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout mesakit-extensions for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Ignoring matched checkout telenav-superpom for pull request - because we are matching the branch feature/testing but it is on the branch develop
[INFO] Will include telenav-build in the pull request set, on branch feature/testing
[WARNING] Every checkout matched already has an open, mergeable PR.  Nothing to do.
@jonathanl-telenav
Copy link
Contributor Author

I got this started. See the branch feature/build-log-48

@timboudreau
Copy link
Collaborator

I cannot tell what changes in BuildLog, since it looks like the entire source file has had its class members sorted. Please don't do that on code that already has a git history.

@jonathanl-telenav
Copy link
Contributor Author

sure fair enough, but we need to agree on how new files should be sorted initially then, don't you think? a random ordering makes classes pretty messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants