Merge pull request #348 from Tinyblargon/fix-description

fix: can't clear `description`
Telmate · Jul 26, 2024 · 4c4580d · 4c4580d
2 parents b5ee3f5 + 43cbc51
commit 4c4580d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/proxmox/config_qemu.go b/proxmox/config_qemu.go
@@ -183,19 +183,15 @@ func (config ConfigQemu) mapToAPI(currentConfig ConfigQemu, version Version) (re
 	if config.Boot != "" {
 		params["boot"] = config.Boot
 	}
+	if config.Description != nil && (*config.Description != "" || currentConfig.Description != nil) {
+		params["description"] = *config.Description
+	}
 	if config.QemuCores != 0 {
 		params["cores"] = config.QemuCores
 	}
 	if config.QemuCpu != "" {
 		params["cpu"] = config.QemuCpu
 	}
-	if config.Description != nil {
-		if *config.Description != "" {
-			params["description"] = *config.Description
-		} else if currentConfig.Description != nil {
-			itemsToDelete += ",description"
-		}
-	}
 	if config.Hookscript != "" {
 		params["hookscript"] = config.Hookscript
 	}

diff --git a/proxmox/config_qemu_test.go b/proxmox/config_qemu_test.go
@@ -630,7 +630,7 @@ func Test_ConfigQemu_mapToAPI(t *testing.T) {
 				{name: `Description empty`,
 					config:        &ConfigQemu{Description: util.Pointer("")},
 					currentConfig: ConfigQemu{Description: util.Pointer("old description")},
-					output:        map[string]interface{}{"delete": "description"}}}},
+					output:        map[string]interface{}{"description": ""}}}},
 		{category: `Disks.Ide`,
 			update: []test{
 				{name: `Disk.Ide.Disk_X DELETE`,