Refactor: mapping disks to API

[Tinyblargon]

While working on #299 I realized the following code could easily be restructured to make it more readable.

proxmox-api-go/proxmox/config_qemu_disk.go

Lines 1005 to 1019 in e1cc849

	func (storages QemuStorages) mapToApiValues(currentStorages QemuStorages, vmID, linkedVmId uint, params map[string]interface{}) (delete string) {
	if storages.Ide != nil {
	delete = storages.Ide.mapToApiValues(currentStorages.Ide, vmID, linkedVmId, params, delete)
	}
	if storages.Sata != nil {
	delete = storages.Sata.mapToApiValues(currentStorages.Sata, vmID, linkedVmId, params, delete)
	}
	if storages.Scsi != nil {
	delete = storages.Scsi.mapToApiValues(currentStorages.Scsi, vmID, linkedVmId, params, delete)
	}
	if storages.VirtIO != nil {
	delete = storages.VirtIO.mapToApiValues(currentStorages.VirtIO, vmID, linkedVmId, params, delete)
	}
	return delete
	}

This restructure would get rid of the following code:

proxmox-api-go/proxmox/config_qemu_disk_ide.go

Lines 60 to 79 in e1cc849

	tmpCurrentDisks := QemuIdeDisks{}
	if currentDisks != nil {
	tmpCurrentDisks = *currentDisks
	}
	diskMap := disks.mapToIntMap()
	currentDiskMap := tmpCurrentDisks.mapToIntMap()
	for i := range diskMap {
	delete = diskMap[i].convertDataStructure().mapToApiValues(currentDiskMap[i].convertDataStructure(), vmID, LinkedVmId, QemuDiskId("ide"+strconv.Itoa(int(i))), params, delete)
	}
	return delete
	}
	func (disks QemuIdeDisks) mapToIntMap() map[uint8]*QemuIdeStorage {
	return map[uint8]*QemuIdeStorage{
	0: disks.Disk_0,
	1: disks.Disk_1,
	2: disks.Disk_2,
	3: disks.Disk_3,
	}
	}

proxmox-api-go/proxmox/config_qemu_disk_sata.go

Lines 62 to 83 in e1cc849

	tmpCurrentDisks := QemuSataDisks{}
	if currentDisks != nil {
	tmpCurrentDisks = *currentDisks
	}
	diskMap := disks.mapToIntMap()
	currentDiskMap := tmpCurrentDisks.mapToIntMap()
	for i := range diskMap {
	delete = diskMap[i].convertDataStructure().mapToApiValues(currentDiskMap[i].convertDataStructure(), vmID, LinkedVmId, QemuDiskId("sata"+strconv.Itoa(int(i))), params, delete)
	}
	return delete
	}
	func (disks QemuSataDisks) mapToIntMap() map[uint8]*QemuSataStorage {
	return map[uint8]*QemuSataStorage{
	0: disks.Disk_0,
	1: disks.Disk_1,
	2: disks.Disk_2,
	3: disks.Disk_3,
	4: disks.Disk_4,
	5: disks.Disk_5,
	}
	}

proxmox-api-go/proxmox/config_qemu_disk_scsi.go

Lines 91 to 137 in e1cc849

	tmpCurrentDisks := QemuScsiDisks{}
	if currentDisks != nil {
	tmpCurrentDisks = *currentDisks
	}
	diskMap := disks.mapToIntMap()
	currentDiskMap := tmpCurrentDisks.mapToIntMap()
	for i := range diskMap {
	delete = diskMap[i].convertDataStructure().mapToApiValues(currentDiskMap[i].convertDataStructure(), vmID, linkedVmId, QemuDiskId("scsi"+strconv.Itoa(int(i))), params, delete)
	}
	return delete
	}
	func (disks QemuScsiDisks) mapToIntMap() map[uint8]*QemuScsiStorage {
	return map[uint8]*QemuScsiStorage{
	0: disks.Disk_0,
	1: disks.Disk_1,
	2: disks.Disk_2,
	3: disks.Disk_3,
	4: disks.Disk_4,
	5: disks.Disk_5,
	6: disks.Disk_6,
	7: disks.Disk_7,
	8: disks.Disk_8,
	9: disks.Disk_9,
	10: disks.Disk_10,
	11: disks.Disk_11,
	12: disks.Disk_12,
	13: disks.Disk_13,
	14: disks.Disk_14,
	15: disks.Disk_15,
	16: disks.Disk_16,
	17: disks.Disk_17,
	18: disks.Disk_18,
	19: disks.Disk_19,
	20: disks.Disk_20,
	21: disks.Disk_21,
	22: disks.Disk_22,
	23: disks.Disk_23,
	24: disks.Disk_24,
	25: disks.Disk_25,
	26: disks.Disk_26,
	27: disks.Disk_27,
	28: disks.Disk_28,
	29: disks.Disk_29,
	30: disks.Disk_30,
	}
	}

proxmox-api-go/proxmox/config_qemu_disk_virtio.go

Lines 74 to 105 in e1cc849

	tmpCurrentDisks := QemuVirtIODisks{}
	if currentDisks != nil {
	tmpCurrentDisks = *currentDisks
	}
	diskMap := disks.mapToIntMap()
	currentDiskMap := tmpCurrentDisks.mapToIntMap()
	for i := range diskMap {
	delete = diskMap[i].convertDataStructure().mapToApiValues(currentDiskMap[i].convertDataStructure(), vmID, linkedVmId, QemuDiskId("virtio"+strconv.Itoa(int(i))), params, delete)
	}
	return delete
	}
	func (disks QemuVirtIODisks) mapToIntMap() map[uint8]*QemuVirtIOStorage {
	return map[uint8]*QemuVirtIOStorage{
	0: disks.Disk_0,
	1: disks.Disk_1,
	2: disks.Disk_2,
	3: disks.Disk_3,
	4: disks.Disk_4,
	5: disks.Disk_5,
	6: disks.Disk_6,
	7: disks.Disk_7,
	8: disks.Disk_8,
	9: disks.Disk_9,
	10: disks.Disk_10,
	11: disks.Disk_11,
	12: disks.Disk_12,
	13: disks.Disk_13,
	14: disks.Disk_14,
	15: disks.Disk_15,
	}
	}