feat: implement ability to clone Qemu VM to different storage #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows cloning a Qemu VM to a different storage location without changing the original configuration. This is already documented in the README.md but was not implemented yet.
OidaTiftla
force-pushed
the
allow-clone-to-user-defined-storage
branch
from
d5be3ac
to
0b6d93c
Compare
|
Hi @Tinyblargon, I don't know what is the correct workflow and if I need to mention you on this pull request. Let me known if there's anything I need to modify so this can be merged. Kind regards, |
Tinyblargon
reviewed
Aug 19, 2024
| @@ -35,6 +35,27 @@ func Test_Clone_Qemu_VM(t *testing.T) { | |||
|
|
|||
| } | |||
|
|
|||
| func Test_Clone_Qemu_VM_To_Different_Storage(t *testing.T) { | |||
There was a problem hiding this comment.
currently none of the API test are really functional but this tells us what situation we should have coverage for.
Co-authored-by: Okean <[email protected]>
|
@Tinyblargon thanks for your feedback. You may have a look at the updated version. |
Tinyblargon
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I want to create a clone to a different storage as it is possible through the Web UI and I noticed that this option is already documented in the README.md, but not yet implemented.
The changes in this PR will allow cloning a Qemu VM to a different storage location without changing the original configuration.
I also added a unit test, but I could not run and verify the unit test with
make test. I did not found out how to setup the unit test so the new storageother-storagewill exist when the unit test runs. Should I keep the new unit test, or should I remove it?Nevertheless I testet the change on my Proxmox 8 and it worked.
If there is anything I can improve in this PR, please let me know 😉.