Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drawer] React 版本 Drawer 在 showInAttachedElement 属性为 true 的情况下， push mode 没有生效 #2607

Closed
4yan opened this issue Nov 21, 2023 · 6 comments
Closed

[Drawer] React 版本 Drawer 在 showInAttachedElement 属性为 true 的情况下， push mode 没有生效 #2607

4yan opened this issue Nov 21, 2023 · 6 comments
Labels
🐞 bug Something isn't working example Something about example to be published fixed, not be published

Comments

@4yan
Copy link

4yan commented Nov 21, 2023

tdesign-react 版本

1.3.1

重现链接

https://tdesign.tencent.com/react/components/drawer?tab=demo

重现步骤

官方 demo 即可复现

期望结果

No response

实际结果

No response

框架版本

React

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response
@github-actions GitHub Actions
Copy link
Contributor

👋 @4yan，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions GitHub Actions
Copy link
Contributor

♥️ 有劳 @xianshannan @LittlehorseXie 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @4yan 。

@HaixingOoO
Copy link
Collaborator

@4yan 你是想表达Drawer 在 showInAttachedElement 属性为 true 的情况下， push mode 没有生效，mode=push没生效是说的内容没有被推开的意思是吗？

@HaixingOoO HaixingOoO added example Something about example need more info 需要更多信息理解 issue 的问题 labels Nov 21, 2023
@4yan
Copy link
Author

4yan commented Nov 22, 2023

@HaixingOoO 是的，我看在vue版本下是有推开的，但react 版本没有做，所以不清楚是bug还是特性

@HaixingOoO
Copy link
Collaborator

HaixingOoO commented Nov 22, 2023 •
edited
Loading

@HaixingOoO 是的，我看在vue版本下是有推开的，但react 版本没有做，所以不清楚是bug还是特性

OK，感谢您的issue，确实是bug，目前支持的是body元素的push，后续修复！！

@HaixingOoO HaixingOoO added the 🐞 bug Something isn't working label Nov 22, 2023
@HaixingOoO HaixingOoO mentioned this issue Nov 26, 2023
Merged
16 tasks
@uyarn uyarn added to be published fixed, not be published and removed need more info 需要更多信息理解 issue 的问题 labels Nov 27, 2023
@uyarn
Copy link
Collaborator

uyarn commented Nov 30, 2023

fixed 1.4.0

@uyarn uyarn closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working example Something about example to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@uyarn @4yan @HaixingOoO