Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] classname 的错误挂载 #2619

Closed
NWYLZW opened this issue Nov 28, 2023 · 4 comments
Closed

[Dialog] classname 的错误挂载 #2619

NWYLZW opened this issue Nov 28, 2023 · 4 comments
Assignees
Labels
🎨 design Something about design or style to be published fixed, not be published

Comments

@NWYLZW
Copy link
Collaborator

NWYLZW commented Nov 28, 2023

tdesign-react 版本

重现链接

重现步骤

使用 Dialog 相关组件的同时为其添加 classname。

期望结果

只在一个 div 节点上添加。

实际结果

55063bae-6352-4c1d-8585-95a79966bead

框架版本

18.2.0

浏览器版本

系统版本

Node版本

补充说明

如果在俩个节点上添加后,想控制某一特定节点时就必须附加上别的选择器才能选择到对应的元素。

比如说我需要控制 .t-dialog 我就必须写这个选择器 .t-dialog.xxx-class,控制上面 ctx 必须写 .t-dialog__ctx.xxx-class
否则就无法选择到准确的目标的节点。

@NWYLZW NWYLZW added 🎨 design Something about design or style 💭 discussion we are discussing labels Nov 28, 2023
Copy link
Contributor

👋 @NWYLZW,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

Copy link
Contributor

♥️ 有劳 @ldwonday @psaren @huoyuhao @honkinglin 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @NWYLZW

@NWYLZW
Copy link
Collaborator Author

NWYLZW commented Nov 28, 2023

vue、vue-next 存在默认透传,可能设计上将对应的 class 放置最顶层是比较兼容的表现。
然后也可以再新增特定的 class 用作内部元素的样式。

(实际上来说我个人的观点是 class 传递给 dialog,而 ctx 单独设置特定的 classname)

@HaixingOoO
Copy link
Collaborator

fix 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Something about design or style to be published fixed, not be published
Projects
None yet
Development

No branches or pull requests

3 participants