Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] 在loading状态变更时children中的内容会重新渲染 #2997

Closed
huangchen1031 opened this issue Jul 18, 2024 · 3 comments · Fixed by #3051
Closed

[Card] 在loading状态变更时children中的内容会重新渲染 #2997

huangchen1031 opened this issue Jul 18, 2024 · 3 comments · Fixed by #3051
Labels
improvement to be published fixed, not be published

Comments

@huangchen1031
Copy link
Collaborator

tdesign-react 版本

1.7.6

重现链接

https://stackblitz.com/edit/react-dngjcg?file=src%2Fdemo.tsx

重现步骤

如题

期望结果

期望在loading变化时不要重新渲染children

实际结果

No response

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response
@github-actions GitHub Actions
Copy link
Contributor

👋 @huangchen1031，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@HaixingOoO
Copy link
Collaborator

欢迎PR！！！

@huangchen1031
Copy link
Collaborator Author

欢迎PR！！！

这个改起来还算简单，然而我看到loading属性还支持TNode却并未实现，这可就是另外的价钱了！

huangchen1031 added a commit to huangchen1031/tdesign-react that referenced this issue Aug 20, 2024
@huangchen1031
fix(card): loading属性增加TNode支持
c770aa8 
fix Tencent#2997
huangchen1031 added a commit to huangchen1031/tdesign-react that referenced this issue Aug 20, 2024
@huangchen1031
fix(card): loading属性增加TNode支持
56a8d03 
fix Tencent#2997
@huangchen1031 huangchen1031 mentioned this issue Aug 20, 2024
Merged
15 tasks
@uyarn uyarn added the to be published fixed, not be published label Aug 28, 2024
@uyarn uyarn closed this as completed in 3f9a77a Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(card): loading属性增加TNode支持 huangchen1031/tdesign-react
3 participants
@huangchen1031 @uyarn @HaixingOoO