Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[全局配置]GlobalConfigProvider的attach 为什么只对Dialog,Select等生效,对于Drawer以及插件类MessagePlugin,DialogPlugin不生效 #3266

Closed
EOMHH opened this issue Dec 5, 2024 · 5 comments
Labels
enhancement New feature or request to be published fixed, not be published

Comments

@EOMHH
Copy link

EOMHH commented Dec 5, 2024

tdesign-react 版本

1.10.1

重现链接

https://tdesign.tencent.com/react/global-configuration?tab=api

重现步骤

使用全局配置 attach
image

期望结果

Drawer可挂载到全局配置的节点

实际结果

Drawer仍然在body上
image

框架版本

17.0.1

浏览器版本

131.0.6778.86

系统版本

14.6.1

Node版本

15.9.0

补充说明

No response

Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 @EOMHH,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@huangchen1031
Copy link
Collaborator

因为全局的attach只支持了DialogImageViewerPopup,至于Plugin的用法那就是另一个故事了。。。
@HaixingOoO 大佬看看,useAttach是不是在Portal里面调的话更通用一些。

@uyarn uyarn added the enhancement New feature or request label Dec 5, 2024
@uyarn
Copy link
Collaborator

uyarn commented Dec 5, 2024

当时和@HaixingOoO @NWYLZW 讨论的是根据业务需求优先支持业务需要且改动小的组件,其他组件有全局attach的需求也可以实现

@uyarn
Copy link
Collaborator

uyarn commented Dec 9, 2024

drawer会支持attach的全局配置,messagePlugin涉及改动较大,后续再讨论支持

@uyarn uyarn added the to be published fixed, not be published label Dec 9, 2024
@uyarn
Copy link
Collaborator

uyarn commented Dec 19, 2024

support drawer global attach config 1.10.2

@uyarn uyarn closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to be published fixed, not be published
Projects
None yet
Development

No branches or pull requests

3 participants