Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image-viewer] 能否增加按下ESC时是否触发对话框关闭事件，Upload theme="image"时可透传ImageViewer全部属性 #2928

Closed
ls-v opened this issue Jun 1, 2023 · 2 comments
Closed

[image-viewer] 能否增加按下ESC时是否触发对话框关闭事件，Upload theme="image"时可透传ImageViewer全部属性 #2928

ls-v opened this issue Jun 1, 2023 · 2 comments
Labels
💪🏻 enhancement New feature or request

Comments

@ls-v
Copy link

ls-v commented Jun 1, 2023

这个功能解决了什么问题

#2704

你建议的方案是什么

ImageViewer 增加closeOnEscKeydown，Upload 可透传ImageViewer全部属性
@ls-v ls-v changed the title ImageViewer 能否增加按下ESC时是否触发对话框关闭事件，Upload theme="image"时可透传ImageViewer全部属性 [ImageViewer] 能否增加按下ESC时是否触发对话框关闭事件，Upload theme="image"时可透传ImageViewer全部属性 Jun 2, 2023
@ls-v ls-v changed the title [ImageViewer] 能否增加按下ESC时是否触发对话框关闭事件，Upload theme="image"时可透传ImageViewer全部属性 [image-viewer] 能否增加按下ESC时是否触发对话框关闭事件，Upload theme="image"时可透传ImageViewer全部属性 Jun 6, 2023
@chaishi
Copy link
Collaborator

chaishi commented Nov 5, 2023

  • feat(ImageViewer): 新增支持 closeOnEscKeydown，用于控制是否允许 ESC 退出预览
  • feat(Upload): 图片预览功能，新增支持透传图片预览全部属性 imageViewerProps

resolved in #3566

@chaishi chaishi added the 💪🏻 enhancement New feature or request label Nov 5, 2023
@chaishi chaishi mentioned this issue Nov 5, 2023
Merged
16 tasks
@uyarn uyarn added the to be published to be published label Nov 6, 2023
@chaishi chaishi mentioned this issue Nov 6, 2023
Merged
16 tasks
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
16 tasks
@chaishi
Copy link
Collaborator

chaishi commented Nov 7, 2023

resolved at v1.6.8 2023-11-07

@chaishi chaishi closed this as completed Nov 7, 2023
@chaishi chaishi removed the to be published to be published label Nov 7, 2023
@chaishi chaishi mentioned this issue Nov 7, 2023
Closed
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪🏻 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chaishi @ls-v @uyarn