Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TagInput] 扩展 collapsedItems 的删除功能 #2941

Closed
topazur opened this issue Dec 1, 2023 · 2 comments
Closed

[TagInput] 扩展 collapsedItems 的删除功能 #2941

topazur opened this issue Dec 1, 2023 · 2 comments
Assignees
@chaishi @PengYYYYY
Labels
to be published fixed, not be published

Comments

@topazur
Copy link
Contributor

topazur commented Dec 1, 2023

这个功能解决了什么问题

  1. 统一 collapsedItems 的类型定义 （为什么只需要 value 和 onClose？其他属性都可以在外部拿到，且 onClose 仅需要 event 和 index 参数即可）
  2. 统一文档及示例交互形式。
  3. 涉及UI/交互变动需要有截图或 GIF。
image

你建议的方案是什么

Tencent/tdesign-react#2630
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

👋 @topazur，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

♥️ 有劳 @chaishi @PengYYYYY 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @topazur 。

topazur added a commit to topazur/tdesign-vue-repo that referenced this issue Dec 1, 2023
@topazur
feat(TagInput): expand the deletion function of collapsedItems(Tencen…
e506d32 
…t#2941)
@topazur topazur mentioned this issue Dec 1, 2023
Merged
16 tasks
topazur added a commit to topazur/tdesign-vue-repo that referenced this issue Dec 1, 2023
@topazur
fix(TagInput): onClose parameter(Tencent#2941)
431a3e7
@uyarn uyarn added the 🏃🏻 in progress someone is handling label Dec 7, 2023
@uyarn uyarn added to be published fixed, not be published and removed 🏃🏻 in progress someone is handling labels Mar 27, 2024
uyarn added a commit that referenced this issue Mar 27, 2024
@topazur @uyarn
feat(TagInput): expand the deletion function of collapsedItems(#2941) (…
666cc27 
…#2942)

* feat(TagInput): expand the deletion function of collapsedItems(#2941)

* fix(TagInput): onClose parameter(#2941)

* chore: update api

* chore: update api

* chore: update api

* chore: update api

---------

Co-authored-by: Uyarn <[email protected]>
uyarn added a commit that referenced this issue Apr 11, 2024
@topazur @uyarn
feat(TagInput): expand the deletion function of collapsedItems(#2941) (…
9b8bf08 
…#2942)

* feat(TagInput): expand the deletion function of collapsedItems(#2941)

* fix(TagInput): onClose parameter(#2941)

* chore: update api

* chore: update api

* chore: update api

* chore: update api

---------

Co-authored-by: Uyarn <[email protected]>
@uyarn uyarn closed this as completed Apr 11, 2024
uyarn added a commit that referenced this issue Apr 11, 2024
@uyarn @maoyiluo
@betavs @XBIsland @topazur @LoopZhou @Lyan-u @Summer-Shen
chore: release 1.9.2-naruto (#3141)
773ecce 
* chore: update group code (#3111)

* feat(Tag): 增加自定义颜色参数 (#3101)

* feat(tag): add color attribute to t-tag in order to customize tag color

feat #3004

* feat: tag自定义颜色下light和light-outline的背景色使用计算的色阶展示

feat #3004

* feat: 补充缺失的类型

* refactor(tag): 将获取颜色样式的代码抽取成方法

* feat(tag): 改用chorma计算色阶

* chore: update snapshot

* chore: update demo display

* feat(tag): use transparent color for the light mode t-tag when using with color props

* chore: update snapshot

* feat: 补充类型声明 & 清理多余依赖

---------

Co-authored-by: Uyarn <[email protected]>

* fix(transfer): trigger exception for the search event (#3118)

* chore: fix image locale and update snapshot (#3119)

* fix(loading): export directive alias (#3120)

Co-authored-by: yojim <[email protected]>

* feat(TagInput): expand the deletion function of collapsedItems(#2941) (#2942)

* feat(TagInput): expand the deletion function of collapsedItems(#2941)

* fix(TagInput): onClose parameter(#2941)

* chore: update api

* chore: update api

* chore: update api

* chore: update api

---------

Co-authored-by: Uyarn <[email protected]>

* fix(checkbox): checkboxGroup max effects disable status

* docs(dialog): add comment for usage precautions (#3126)

* fix(date-picker): over parse when valueType is Date (#3127)

* fix(date-picker): over parse when valueType is Date

* chore: fix lint

* docs(dialog): mention destroy DOM elements in dialog.md (#3125)

* docs(dialog): mention destroy DOM elements in dialog.md

* docs(dialog): add more specific description in dialog.md

* docs(dialog): update translations in dialog.en-US.md

* docs(dialog): update colons in dialog.en-US.md

* fix(menu): remove usage of `height` in menu demos (#3135)

* fix(menu): remove usage of `height` in menu demos

* fix(menu): update snapshots

* fix(table): use the `fixedRows` property console to report errors (#3134)

* fix(Transfer): fix tree data filter error (#3137)

* fix(Transfer): fix tree data filter error

* fix(Transfer): fix tree data filter error

* fix(datepicker): fix datepicker week parse error (#3138)

* chore: rename loading directive export (#3140)

* chore: release 1.9.2 (#3139)

* chore: release 1.9.2

* chore: update snapshot

---------

Co-authored-by: maoyiluo <[email protected]>
Co-authored-by: betavs <[email protected]>
Co-authored-by: Yoki <[email protected]>
Co-authored-by: yojim <[email protected]>
Co-authored-by: odinlin <[email protected]>
Co-authored-by: LoopZhou <[email protected]>
Co-authored-by: Lyan-u <[email protected]>
Co-authored-by: Yunfei Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaishi chaishi

@PengYYYYY PengYYYYY

Labels
to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chaishi @uyarn @PengYYYYY @topazur