Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionParameters type does not have save or save_if_fails #98

Open
marcusmolchany opened this issue Aug 24, 2023 · 1 comment · May be fixed by #99
Open

TransactionParameters type does not have save or save_if_fails #98

marcusmolchany opened this issue Aug 24, 2023 · 1 comment · May be fixed by #99

Comments

@marcusmolchany
Copy link
Contributor

We're trying to use the SDK to simulate a transaction bundle and save the results to the dashboard, and it appears that the save and save_if_fails options are not available in the SDK.

TransactionParameters types where I would expect save and save_if_fails: https://github.com/Tenderly/tenderly-sdk/blob/master/lib/executors/Simulator.types.ts#L3-L13

Where I would expect save and save_if_fails for tx simulation bundles: https://github.com/Tenderly/tenderly-sdk/blob/master/lib/executors/Simulator.ts#L128-L138

Where I would expect save and save_if_fails for an individual tx simulation: https://github.com/Tenderly/tenderly-sdk/blob/master/lib/executors/Simulator.ts#L153-L163

We're happy to make this change if these are the right places to update.

@marcusmolchany
Copy link
Contributor Author

@marcusmolchany marcusmolchany linked a pull request Aug 24, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant