Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server dependencies come in client's classpath #99

Open
mathieucarbou opened this issue Oct 12, 2016 · 1 comment
Open

Server dependencies come in client's classpath #99

mathieucarbou opened this issue Oct 12, 2016 · 1 comment
Assignees

Comments

@mathieucarbou
Copy link
Member

mathieucarbou commented Oct 12, 2016

Integration tests in Ehcache are not able to detect issues like this:

ehcache/ehcache3#1535

The reason is that Galvan depends on passthrough, and passthrough depends on all tc apis jars (including server apis). Thus, the client's classpath of the integration tests contain all the server apis also.

To have real integration tests, client classpath should stick with client libs and server libs should not come transitively from Galvan.

The proposed solution is to exclude all server jars coming in Galvan from passthrough, and if Galvan code depends on some server libs, then they should be declared in galvan's pom file with a provided scope. This way they won't come into the client's classpath.

http://i.imgur.com/aaMtnAv.png

@myronkscott
Copy link
Member

@mathieucarbou is this still an issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants