ArcGisImageServerCatalogItemSpec.ts fails when using build-specs

[pjonsson]

Running:

yarn install
yarn gulp build-specs
xvfb-run --auto-servernum yarn gulp test-firefox

in the node:18 docker image started failing between TerriaJS 8.7.5 and 8.7.6, here's the end of the log on my screen:

24) creates correct image resource
     ArcGisImageServerImageryProvider tiled web mercator
     Error: [MobX] No annotations were passed to makeObservable, but no decorated members have been found either in build/TerriaJS-specs.js line 30374 > eval (line 154)
die@webpack-internal:///./node_modules/mobx/dist/mobx.esm.js:154:11
collectStoredAnnotations@webpack-internal:///./node_modules/mobx/dist/mobx.esm.js:471:10
makeObservable@webpack-internal:///./node_modules/mobx/dist/mobx.esm.js:3400:73
ArcGisImageServerImageryProvider@webpack-internal:///./lib/Map/ImageryProvider/ArcGisImageServerImageryProvider.ts:92:30
_callee24$@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:720:31
tryCatch@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:1062
makeInvokeMethod/<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:3020
defineIteratorMethods/</<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:1699
asyncGeneratorStep@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:42:103
_next@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:212
_asyncToGenerator/</<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:369
_asyncToGenerator/<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:97
     TypeError: imageryProvider is undefined in build/TerriaJS-specs.js line 51438 > eval (line 765)
@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:765:7

25) picks features
     ArcGisImageServerImageryProvider tiled web mercator
     Error: [MobX] No annotations were passed to makeObservable, but no decorated members have been found either in build/TerriaJS-specs.js line 30374 > eval (line 154)
die@webpack-internal:///./node_modules/mobx/dist/mobx.esm.js:154:11
collectStoredAnnotations@webpack-internal:///./node_modules/mobx/dist/mobx.esm.js:471:10
makeObservable@webpack-internal:///./node_modules/mobx/dist/mobx.esm.js:3400:73
ArcGisImageServerImageryProvider@webpack-internal:///./lib/Map/ImageryProvider/ArcGisImageServerImageryProvider.ts:92:30
_callee24$@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:720:31
tryCatch@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:1062
makeInvokeMethod/<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:3020
defineIteratorMethods/</<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:1699
asyncGeneratorStep@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:42:103
_next@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:212
_asyncToGenerator/</<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:369
_asyncToGenerator/<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:97
     TypeError: imageryProvider is undefined in build/TerriaJS-specs.js line 51438 > eval (line 775)
_callee25$@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:775:13
tryCatch@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:1062
makeInvokeMethod/<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:3020
defineIteratorMethods/</<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:41:1699
asyncGeneratorStep@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:42:103
_next@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:212
_asyncToGenerator/</<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:369
_asyncToGenerator/<@webpack-internal:///./test/Models/Catalog/esri/ArcGisImageServerCatalogItemSpec.ts:43:97


[16:54:14] 'test-firefox' errored after 1.23 min

I spent 2 hours on trying to pin this down, but the main branch is broken on every other commit, so I will leave this as is so someone else can sort this out. I'm guessing the problem was introduced with #7146.